Migrate AzureRmWebAppDeploymentV4 and IISWebAppDeploymentOnMachineGro…

…upV0 to Node20 (#19371) * Migrate 2 tasks * merge _generated node16 tasks to base
microsoft · Jan 15, 2024 · b5b4b7d · b5b4b7d
1 parent 336d467
commit b5b4b7d
Show file tree

Hide file tree

Showing 257 changed files with 627 additions and 18,832 deletions.
diff --git a/...ildConfigs/Node16/Tests/package-lock.json → ...ildConfigs/Node20/Tests/package-lock.json b/...ildConfigs/Node16/Tests/package-lock.json → ...ildConfigs/Node20/Tests/package-lock.json
diff --git a/...4/_buildConfigs/Node16/Tests/package.json → ...4/_buildConfigs/Node20/Tests/package.json b/...4/_buildConfigs/Node16/Tests/package.json → ...4/_buildConfigs/Node20/Tests/package.json
diff --git a/...ureRmWebAppDeploymentV4/package-lock.json → ...V4/_buildConfigs/Node20/package-lock.json b/...ureRmWebAppDeploymentV4/package-lock.json → ...V4/_buildConfigs/Node20/package-lock.json
diff --git a/...eRmWebAppDeploymentV4_Node16/package.json → ...ymentV4/_buildConfigs/Node20/package.json b/...eRmWebAppDeploymentV4_Node16/package.json → ...ymentV4/_buildConfigs/Node20/package.json
@@ -18,10 +18,9 @@
   "homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
   "dependencies": {
     "@types/mocha": "^5.2.7",
-    "@types/node": "^16.11.39",
+    "@types/node": "^20.3.1",
     "@types/q": "1.0.7",
-    "agent-base": "^6.0.2",
-    "azure-pipelines-task-lib": "4.4.0",
+    "azure-pipelines-task-lib": "^3.4.0",
     "azure-pipelines-tasks-azure-arm-rest": "3.223.5",
     "azure-pipelines-tasks-webdeployment-common": "4.230.6",
     "moment": "^2.29.4",
@@ -30,6 +29,6 @@
     "xml2js": "^0.6.0"
   },
   "devDependencies": {
-    "typescript": "4.0.2"
+    "typescript": "5.1.6"
   }
 }
diff --git a/Tasks/AzureRmWebAppDeploymentV4/make.json b/Tasks/AzureRmWebAppDeploymentV4/make.json
@@ -18,7 +18,8 @@
         {
             "items": [
                 "node_modules/azure-pipelines-tasks-azure-arm-rest/node_modules/azure-pipelines-task-lib",
-                "node_modules/azure-pipelines-tasks-webdeployment-common/node_modules/azure-pipelines-task-lib"
+                "node_modules/azure-pipelines-tasks-webdeployment-common/node_modules/azure-pipelines-task-lib",
+                "node_modules/https-proxy-agent/node_modules/agent-base"
             ],
             "options": "-Rf"
         }

diff --git a/Tasks/AzureRmWebAppDeploymentV4/operations/PublishProfileUtility.ts b/Tasks/AzureRmWebAppDeploymentV4/operations/PublishProfileUtility.ts
@@ -108,15 +108,9 @@ export class PublishProfileUtility {
 			   outStream: process.stdout,
 			   failOnStdErr: true,
                windowsVerbatimArguments: true,
-#if NODE16
                // shell should be true, otherwise see https://github.com/microsoft/azure-pipelines-tasks/issues/17634
                // workaround https://github.com/nodejs/node/issues/7367#issuecomment-229728704
                shell: true 
-#elseif NODE20
-               // shell should be true, otherwise see https://github.com/microsoft/azure-pipelines-tasks/issues/17634
-               // workaround https://github.com/nodejs/node/issues/7367#issuecomment-229728704
-               shell: true 
-#endif
              });
         } catch (error) {
             cmdError = error;