ApplicationTokenCredentials.initOIDCToken: Extend retry mechanism for exceptions #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several mseng release pipelines we are experiencing flaky issues when trying to fetch OIDC token for AzureKeyVault tasks (see the bug here). OIDC token is provided by OIDC token API (see controller and API specification). It turned out that in some cases request does not reach the server (
ECONNRESETor similar) which leads to the exception on the build agent side, but retry mechanism is missing for these cases. This PR introduces such logic and refactorsApplicationTokenCredentials.initOIDCTokentoasync/awaitstyle function.