Removed unsupported lib, added async methods #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powershell/make-util.js
Outdated
Comment on lines
213
to
224
| var downloadArchive = function (url, fileName) { | ||
| var result; | ||
| downloadArchiveAsync(url, fileName).then(t => result = t); | ||
| deasync.loopWhile(function () { return result == undefined; }); | ||
| return result; | ||
| } | ||
|
|
||
| /** | ||
| * @deprecated This method uses library which is not prefered to use on production | ||
| */ | ||
|
|
||
| exports.downloadArchive = downloadArchive; |
There was a problem hiding this comment.
Are we need that for now?
There was a problem hiding this comment.
since this is exported I am not sure is there any user of this method, thus I prefer to keep for a while.
There was a problem hiding this comment.
AFAIK, we don't have make files in the final build, so it's only for internal usage
powershell/make-util.js
Outdated
Comment on lines
161
to
171
| var downloadFile = function (url, fileName) { | ||
| var result; | ||
| downloadFileAsync(url, fileName).then(t => result = t); | ||
| deasync.loopWhile(function () { return result == undefined; }); | ||
| return result; | ||
| } | ||
| exports.downloadFile = downloadFile; | ||
|
|
||
| var downloadArchive = function (url) { | ||
| if (!url) { | ||
| throw new Error('Parameter "url" must be set.'); | ||
| } | ||
| /** | ||
| * @deprecated This method uses library which is not prefered to use on production | ||
| */ | ||
| exports.downloadFile = downloadFile |
There was a problem hiding this comment.
Are we need this function for now?
There was a problem hiding this comment.
KonstantinTyukalov
approved these changes
Jun 9, 2023
|
In general LGTM, but could you please bump task-lib version, confirm that there is no breaking changes and fill changelogs file. |
|
Azure Pipelines successfully started running 2 pipeline(s). |
KonstantinTyukalov
approved these changes
Jun 23, 2023
wojgasior
approved these changes
Jul 6, 2023
kirill-ivlev
approved these changes
Jul 17, 2023
…s://github.com/microsoft/azure-pipelines-task-lib into users/ismayilov-ismayil/remove_unsupported_lib
KonstantinTyukalov
approved these changes
Sep 18, 2023
Drarig29
added a commit
to DataDog/datadog-ci-azure-devops
that referenced
this pull request
Nov 14, 2023
This was referenced Nov 14, 2023
Drarig29
added a commit
to DataDog/datadog-ci-azure-devops
that referenced
this pull request
Nov 15, 2023
* Bump azure-pipelines-task-lib to fix open handles - microsoft/azure-pipelines-task-lib#932 - ForbesLindesay/sync-request#129 * Fix "Could not locate the bindings file" * Run mock tasks asynchronously
Drarig29
added a commit
to DataDog/datadog-ci-azure-devops
that referenced
this pull request
Nov 15, 2023
* Bump azure-pipelines-task-lib to fix open handles - microsoft/azure-pipelines-task-lib#932 - ForbesLindesay/sync-request#129 * Fix "Could not locate the bindings file" * Run mock tasks asynchronously * [dep] Remove superfluous libraries * Try node 10 entrypoint * Revert "Try node 10 entrypoint" This reverts commit b962ed3.
Drarig29
added a commit
to DataDog/datadog-ci-azure-devops
that referenced
this pull request
Nov 15, 2023
* Bump azure-pipelines-task-lib to fix open handles - microsoft/azure-pipelines-task-lib#932 - ForbesLindesay/sync-request#129 * Fix "Could not locate the bindings file" * Run mock tasks asynchronously * [test] Download Node.js only once
DmitriiBobreshev
pushed a commit
that referenced
this pull request
Dec 11, 2023
* Removed unsupported lib, added async methods * Update 3rd party library change to async * Format style in ThirdPartyNotice
DmitriiBobreshev
added a commit
that referenced
this pull request
Dec 13, 2023
* Removed unsupported lib, added async methods (#932) * Removed unsupported lib, added async methods * Update 3rd party library change to async * Format style in ThirdPartyNotice * [Deasync remove] - Remove deasync from task-lib - Remove deasync from node build process * [Deasync remove] - Remove deasync from task-lib - Remove deasync from node build process * [Deasync remove] - Remove deasync from task-lib - Remove deasync from node build process - Fixed unit tests - Updated json * Added publish script for PowerShell SDK (#975) * simple yampl to create pipeline * Add additional steps into pipeline to publish nuget feed * Upgrade net framework version * Revert csproj changes * Specify msbuild version for old netframework support * Add arch argument to msbuild installation * Bump package version * Use nuspec version directly * Fix downloadFileAsync * rm committed minimatch dll * Move publish steps to job + temp disable it * Move version to package back. Fix encoding * Add publish script * Update tags * update company metadata * Update to publish to powershell gallery --------- Co-authored-by: Konstantin Tyukalov <v-ktyukalov@microsoft.com> Co-authored-by: Konstantin Tyukalov <52399739+KonstantinTyukalov@users.noreply.github.com> * [Deasync remove] - Remove deasync from task-lib - Code review changes --------- Co-authored-by: İsmayıl İsmayılov <110806089+ismayilov-ismayil@users.noreply.github.com> Co-authored-by: Konstantin Tyukalov <v-ktyukalov@microsoft.com> Co-authored-by: Konstantin Tyukalov <52399739+KonstantinTyukalov@users.noreply.github.com>
DergachevE
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Removed unsupported lib, added async methods (#932) * Removed unsupported lib, added async methods * Update 3rd party library change to async * Format style in ThirdPartyNotice * [Deasync remove] - Remove deasync from task-lib - Remove deasync from node build process * [Deasync remove] - Remove deasync from task-lib - Remove deasync from node build process * [Deasync remove] - Remove deasync from task-lib - Remove deasync from node build process - Fixed unit tests - Updated json * Added publish script for PowerShell SDK (#975) * simple yampl to create pipeline * Add additional steps into pipeline to publish nuget feed * Upgrade net framework version * Revert csproj changes * Specify msbuild version for old netframework support * Add arch argument to msbuild installation * Bump package version * Use nuspec version directly * Fix downloadFileAsync * rm committed minimatch dll * Move publish steps to job + temp disable it * Move version to package back. Fix encoding * Add publish script * Update tags * update company metadata * Update to publish to powershell gallery --------- Co-authored-by: Konstantin Tyukalov <v-ktyukalov@microsoft.com> Co-authored-by: Konstantin Tyukalov <52399739+KonstantinTyukalov@users.noreply.github.com> * [Deasync remove] - Remove deasync from task-lib - Code review changes --------- Co-authored-by: İsmayıl İsmayılov <110806089+ismayilov-ismayil@users.noreply.github.com> Co-authored-by: Konstantin Tyukalov <v-ktyukalov@microsoft.com> Co-authored-by: Konstantin Tyukalov <52399739+KonstantinTyukalov@users.noreply.github.com>
Merged
fullstackinfo
pushed a commit
to fullstackinfo/azure-pipelines-task-lib
that referenced
this pull request
Aug 17, 2024
* Removed unsupported lib, added async methods * Update 3rd party library change to async * Format style in ThirdPartyNotice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: sync-request library not supported any more and has high vulnerability issue
Solution: sync-request package removed. downloadFile and related methods changed to async. To make it backward-compatibly async method wrapped into sync by deasync library.