Added Branch Coverage Information in Coverage Publisher #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eswarnathp
reviewed
Jun 13, 2024
src/CoveragePublisher/Parsers/CoverageParserTools/ReportGeneratorTool.cs
Outdated
Show resolved
Hide resolved
eswarnathp
reviewed
Jun 13, 2024
| @@ -59,9 +60,23 @@ public List<FileCoverageInfo> GetFileCoverageInfos() | |||
| { | |||
| resultFileCoverageInfo.LineCoverageStatus.Add((uint)lineNumber, line == 0 ? CoverageStatus.NotCovered : CoverageStatus.Covered); | |||
| } | |||
|
|
|||
| /// populating branch coverage status | |||
|
|
|||
There was a problem hiding this comment.
Can we have these changes behind feature flag
eswarnathp
reviewed
Jun 13, 2024
vinayakmsft
reviewed
Jun 13, 2024
src/CoveragePublisher/Parsers/CoverageParserTools/ReportGeneratorTool.cs
Outdated
Show resolved
Hide resolved
src/CoveragePublisher/Parsers/CoverageParserTools/ReportGeneratorTool.cs
Outdated
Show resolved
Hide resolved
vinayakmsft
reviewed
Jun 20, 2024
src/CoveragePublisher/Parsers/CoverageParserTools/ReportGeneratorTool.cs
Outdated
Show resolved
Hide resolved
src/CoveragePublisher/Parsers/CoverageParserTools/ReportGeneratorTool.cs
Outdated
Show resolved
Hide resolved
src/CoveragePublisher/Parsers/CoverageParserTools/ReportGeneratorTool.cs
Outdated
Show resolved
Hide resolved
src/CoveragePublisher/Parsers/CoverageParserTools/ReportGeneratorTool.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the Coverage Publisher by adding branch coverage information to the generated cjson files. The Coverage Publisher now processes jacoco.xml, clover.xml, and cobertura.xml files to also include branch coverage data, which is stored as line number and the associated total branches, and covered branches to it.
Details of Changes:
FileCoverageInfo Enhancements:
Added a new dictionary to FileCoverageInfo that maps line numbers to their respective total branches and covered branches.
Report Generator Updates:
Integrated logic to retrieve branch coverage data from the branchesByLine in the code files.
Unit Test Updates:
Updated existing unit tests for FileCoverageInfo to include branch coverage status.
Added new unit tests in the ReportGeneratorToolTest to verify the branch coverage status.
After this is completed the next steps will be -
The cjson files are now equipped with branch coverage data and will be sent to storage.
Planned adjustments to the CoverageMerge job to retrieve and incorporate branch coverage information.
Changes in stored procedures and SQL tables to handle the new branch coverage data.
Output CJSON file for a cobertura.xml input
Output CJSON file for a JaCoCo.xml input