Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent CI] Update signing pipeline to respect the new MinGit layout #3867

Merged

Conversation

alexander-smolyakov
Copy link
Contributor

Issue Description:

Recently our release pipeline failed with the following error on Verify Codesign Report pipeline step:

externals/git/mingw64/lib/python3.9/site-packages/libxml2mod.pyd(File,): error CI0001:  : The file is unsigned.

From the report, we can see that issue comes from the libxml2mod.pyd file that can be found by the following path externals/git/mingw64/lib/python3.9/site-packages

From Codesign Report
  FileName         : libxml2mod.pyd
  Ext              : PYD
  Path             : externals/git/mingw64/lib/python3.9/site-packages/libxml2mod.pyd
  OriginalFileName : 
  Version          : 
  Description      : 
  Product          : 
  Hash             : EA284B1DC6839A3D41DC1DB2DBFD1B237DAA77ECE4E20DBA0532D8271EFC13C3
  UserMode         : True
  Status           : Unsigned

The MinGW distribution comes from the Mingit distribution which we ship with the pipeline agent. Recently we have updated the Mingit version in this pull request:

The Mingit distribution layout was changed between versions 2.30.2 and 2.36.1 and now contains *.pyd files. In the Windows ecosystem, the *.pyd file is a dynamic link library (aka DLL) that contains a Python module or set of modules, to be called by other Python code.

Fix description:

Since *.pyd is a DLL file we need to sign it as well as other *.dll files which means that we have to update a list of patterns for the Sign Agent Assemblies (3rd Party Assemblies Signing) pipeline step to respect *.pyd files.

Changelog:

  • signing.yml: Add pattern to sing the *.pyd files

@alexander-smolyakov alexander-smolyakov added misc Miscellaneous Changes Area: ABTT labels Jun 13, 2022
@alexander-smolyakov alexander-smolyakov requested review from mmrazik and a team June 13, 2022 21:54
@alexander-smolyakov alexander-smolyakov self-assigned this Jun 13, 2022
@alexander-smolyakov alexander-smolyakov merged commit 19db366 into master Jun 14, 2022
@alexander-smolyakov alexander-smolyakov deleted the users/alexander-smolyakov/fix_signing_pipeline branch June 14, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: ABTT misc Miscellaneous Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants