[Agent CI] Update signing pipeline to respect the new MinGit layout #3867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description:
Recently our release pipeline failed with the following error on Verify Codesign Report pipeline step:
externals/git/mingw64/lib/python3.9/site-packages/libxml2mod.pyd(File,): error CI0001: : The file is unsigned.
From the report, we can see that issue comes from the
libxml2mod.pyd
file that can be found by the following pathexternals/git/mingw64/lib/python3.9/site-packages
From Codesign Report
The MinGW distribution comes from the Mingit distribution which we ship with the pipeline agent. Recently we have updated the Mingit version in this pull request:
The Mingit distribution layout was changed between versions
2.30.2
and2.36.1
and now contains*.pyd
files. In the Windows ecosystem, the*.pyd
file is a dynamic link library (aka DLL) that contains a Python module or set of modules, to be called by other Python code.Fix description:
Since
*.pyd
is a DLL file we need to sign it as well as other*.dll
files which means that we have to update a list of patterns for the Sign Agent Assemblies (3rd Party Assemblies Signing) pipeline step to respect*.pyd
files.Changelog:
signing.yml
: Add pattern to sing the*.pyd
files