-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve retry logic for downloading tasks #3857
Merged
DenisRumyantsev
merged 13 commits into
master
from
users/DenisRumyantsev/improve-retry-logic-for-downloading-tasks
Jun 8, 2022
Merged
Improve retry logic for downloading tasks #3857
DenisRumyantsev
merged 13 commits into
master
from
users/DenisRumyantsev/improve-retry-logic-for-downloading-tasks
Jun 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for-downloading-tasks
mmrazik
approved these changes
Jun 7, 2022
max-zaytsev
approved these changes
Jun 7, 2022
KonstantinTyukalov
approved these changes
Jun 7, 2022
alexander-smolyakov
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves logging for downloading tasks during job initialization.
Related issue
Agent logs example:
Pipeline logs example:
Full size of the zip file can not be determined via the result.Length property, and the result.CanSeek property is
false
:GetTaskContentZipAsync
is located inMicrosoft.TeamFoundation.DistributedTask.WebApi.TaskAgentHttpClient
(metadata).During its execution, a
GET
request is sent to Azure DevOps, to get a stream, but not a zip archive with a task, before downloading the zip archive with the task itself. So, the 200 status code in the response does not mean that the task is downloaded successfully, it means that the agent got the stream from the server.