-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix event logs dumping #3810
Merged
KonstantinTyukalov
merged 2 commits into
microsoft:master
from
max-zaytsev:users/max-zaytsev/fix-eventlog-dump
May 19, 2022
Merged
Fix event logs dumping #3810
KonstantinTyukalov
merged 2 commits into
microsoft:master
from
max-zaytsev:users/max-zaytsev/fix-eventlog-dump
May 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
AndreyIvanov42
approved these changes
Apr 7, 2022
anatolybolshakov
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Could you please also reflect other changes in description (like changing of filename extension)?
KonstantinTyukalov
approved these changes
Apr 7, 2022
raghavthind2005
approved these changes
Apr 12, 2022
@mmrazik Could you please take a look at this? |
mmrazik
approved these changes
May 9, 2022
mmrazik
force-pushed
the
users/max-zaytsev/fix-eventlog-dump
branch
from
May 9, 2022 13:57
7ce96bb
to
6378a34
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
StartTime
andEndTime
formats to filter event logs correctly regardless of regional format when collecting diagnostic logs.Related issue: 20 minute pause in the Finalize Job section on a self hosted agent for no apparent reason #3792
More info about The universal sortable ("u") format specifier
Tested manually:
Ran the pipeline PC set to a regional format "English (Australia)" and "English (United States)"