Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent support for the Node v10 runtime #1972

Merged
merged 5 commits into from
Nov 28, 2018

Conversation

juliobbv
Copy link
Contributor

@juliobbv juliobbv commented Nov 14, 2018

Package the Node v10 runtime with the agent, and add a new Node10 handler that can be referenced by the task's task.json.

Additionally, add a feature flag to switch existing Node handler to use either the v6 or the v10 runtimes.

@juliobbv juliobbv changed the title Add agent support for the Node v10 runtime WIP: Add agent support for the Node v10 runtime Nov 14, 2018
@juliobbv juliobbv changed the title WIP: Add agent support for the Node v10 runtime Add agent support for the Node v10 runtime Nov 15, 2018
@juliobbv juliobbv force-pushed the users/juliobv/node10Support branch from 973d564 to 0abb2f1 Compare November 15, 2018 18:39
src/Misc/externals.sh Outdated Show resolved Hide resolved
@juliobbv juliobbv force-pushed the users/juliobv/node10Support branch from 2523a58 to e7dc2c8 Compare November 27, 2018 16:38
@juliobbv juliobbv force-pushed the users/juliobv/node10Support branch from e7dc2c8 to 1767c8c Compare November 27, 2018 19:18
@juliobbv juliobbv force-pushed the users/juliobv/node10Support branch from 1767c8c to abf2042 Compare November 27, 2018 19:49
@TingluoHuang
Copy link
Contributor

@juliobbv LGTM, let me know when you finish all testing and ready to merge. :)

@TingluoHuang TingluoHuang merged commit 6adebd8 into microsoft:master Nov 28, 2018
@juliobbv
Copy link
Contributor Author

@juliobbv LGTM, let me know when you finish all testing and ready to merge. :)

Thanks @TingluoHuang. I finished all of my testing and everything looks good.

@juliobbv juliobbv deleted the users/juliobv/node10Support branch November 28, 2018 17:39
@damccorm
Copy link

This is a continuation of my comment here where I pointed out a place node 10 doesn't honor back-compat, but this seems like a better location for this conversation. I stumbled across another instance of fs being used in a way that is incompatible with node 10, but this time it was in existing task code. I did a quick search of tasks containing fs and after looking at about 25% of them found 4 different instances of fs used in ways that are incompatible with node 10. It will throw a runtime error (so building doesn't catch it).

The places I found them are:

I'd guess there's more instances of this since I only looked at about 25% of tasks containing fs. I'm not sure what the best path forward is here, but it feels like we should be updating those tasks before we turn this on by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants