-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agent support for the Node v10 runtime #1972
Add agent support for the Node v10 runtime #1972
Conversation
973d564
to
0abb2f1
Compare
a697d20
to
2523a58
Compare
2523a58
to
e7dc2c8
Compare
e7dc2c8
to
1767c8c
Compare
1767c8c
to
abf2042
Compare
@juliobbv LGTM, let me know when you finish all testing and ready to merge. :) |
Thanks @TingluoHuang. I finished all of my testing and everything looks good. |
This is a continuation of my comment here where I pointed out a place node 10 doesn't honor back-compat, but this seems like a better location for this conversation. I stumbled across another instance of The places I found them are:
I'd guess there's more instances of this since I only looked at about 25% of tasks containing |
Package the Node v10 runtime with the agent, and add a new
Node10
handler that can be referenced by the task's task.json.Additionally, add a feature flag to switch existing
Node
handler to use either the v6 or the v10 runtimes.