keep tracking created containers, best effort clean them up. #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
force-pushed
the
users/tihuang/dockerimprove2
branch
3 times, most recently
from
9fa7768 to
6609928
Compare
TingluoHuang
force-pushed
the
users/tihuang/dockerimprove2
branch
from
6609928 to
eecfe94
Compare
TingluoHuang
force-pushed
the
users/tihuang/dockerimprove2
branch
3 times, most recently
from
1e3f3ad to
866fdd1
Compare
|
There is also https://docs.docker.com/v17.09/engine/reference/run/#pid-equivalent You may be able to log the container ids to a build-specific file, remove them after succesfully finalizing the job+deleting containers, and have a job to clean up any remaining ones later Im not sure if its any better but just came across this and thought it could possibly be useful |
TingluoHuang
commented
Nov 16, 2018
| public override void Initialize(IHostContext hostContext) | ||
| { | ||
| base.Initialize(hostContext); | ||
| DockerPath = WhichUtil.Which("docker", true, Trace); | ||
| DockerInstanceLabel = IOUtil.GetPathHash(hostContext.GetDirectory(WellKnownDirectory.Bin)).Substring(0, 5); |
There was a problem hiding this comment.
should be Root dir instead of Bin dir.
TingluoHuang
force-pushed
the
users/tihuang/dockerimprove2
branch
from
866fdd1 to
0db4f53
Compare
TingluoHuang
force-pushed
the
users/tihuang/dockerimprove2
branch
from
0db4f53 to
60d6af2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.