fix null ref caused by build.syncsource=false. #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
force-pushed
the
users/tihuang/fixnullref2
branch
2 times, most recently
from
6b3dad8 to
9cb6ab8
Compare
TingluoHuang
force-pushed
the
users/tihuang/fixnullref2
branch
from
9cb6ab8 to
2b7dc0a
Compare
TingluoHuang
commented
Nov 16, 2018
| string defaultWorkingDirectory = executionContext.Variables.Get(Constants.Variables.System.DefaultWorkingDirectory); | ||
| if (string.IsNullOrEmpty(defaultWorkingDirectory)) | ||
| { | ||
| throw new NotSupportedException("System.DefaultWorkingDirectory is required for running container job."); |
There was a problem hiding this comment.
a container job
|
reviewed with Eric. |
TingluoHuang
force-pushed
the
users/tihuang/fixnullref2
branch
from
2b7dc0a to
0a4f5c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.