-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use [ci skip] rather than ***NO_CI*** #1270
Comments
@marceloavf |
What I suggest is to give some options to the user:
|
@marceloavf i would suggest submit your feedback at here: https://visualstudio.uservoice.com/forums/330519-team-services |
…mmit message to [***NO_CI***] microsoft/azure-pipelines-agent#1270
Here's the link, but it's been closed for voting with no comment as to why: Please could someone say why voting is closed? AppVeyor also respects Travis CI support This inconsistency means Azure Pipelines builds when others do not. It wastes resources at Azure Pipelines, can cause confusion when a build is made when it shouldn't, and can cause builds to fail when they shouldn't be run. Thank you! |
https://visualstudio.uservoice.com/forums/330519-azure-devops-formerly-visual-studio-team-services has the announcement about the move to developer community |
Thanks! I found the new issue and the good news is it's being worked on. |
This is available now. You can tell Azure Pipelines to skip running a pipeline that a commit would normally trigger. Just include
|
Can confirm See python-pillow/Pillow#3805 which skipped Travis CI and AppVeyor but not Azure Pipelines. |
See #1270 (comment) for updated version. (copying from my comment posted to Developer Community in response to @hugovk) Here are two test PRs
|
Also works in @mloskot's test repo:
But as mentioned, |
Thanks for reporting this problem. We're looking into it ASAP. |
UPDATE to #1270 (comment)I'm sorry for confusion, but that 'worked' due to issues in my own configuration. Please, forget that comment. I can confirm neither
|
@mloskot and @hugovk , thanks for reporting the issue! Are you currently seeing CI builds running when the [skip ci] or [skip azp] commands are used or only PR builds? Azure DevOps only supports the [skip ci] command variations for CI builds. PR builds will always be run, even if the commit comment contains a [skip ci] command. If adding an option to skip PR builds is feature you would like to see, please be sure to suggest a feature on Developer Community! |
Hi, Could anyone reopen an issue? |
That may explain my confusion. I have seen builds skipped for non-PRs. That convinced me all eorks fine. |
@kelliejos We are not talking about PRs, regular builds aren't skipped. |
I'm talking about PR builds. On the project I mentioned, (virtually) everything is done via feature branches and PRs (as is standard practice on many projects), so I've not seen it on non-PR builds. Travis CI and AppVeyor skip PR (and non-PR) builds when the skip tag is present, it's a command from the author not to expend CI resources on the PR. I don't understand the difference between PR and CI builds on AzP. Aren't PR builds just a subset of CI builds? Is the difference documented somewhere? Thanks! |
For https://github.com/boostorg/gil/ library, Azure Pipelines skip builds for any non-PR commits with
AzP did not start any build at https://dev.azure.com/boostorg/gil/_build You will see there similar commit, as on screenshot below, but this is for a different (previous) commit made on Apr 17 boostorg/gil@db8c76b, which does not contain any So, for Boost.GIL project, skipping has worked fine for long time now. That is why I'm being confused because the skippers have worked for me (for non-PR builds) since day one AzP announced the skipping feature. |
@mloskot and @hugovk Azure DevOps does not permit skipping PR builds as they are gated builds. Allowing a user to bypass gated builds increases the chances that a breaking change could be merged into the code base. Azure DevOps honors the [skip ci] commands on CI builds as the change being built has already been merged. |
@kelliejos Why do you think that you know what end-users want? I want use skippers for all builds. |
Thanks, but for GitHub PRs, it looks really weird when I agree it does increase the chance of a breaking change, but sometimes we really do want to skip all CI builds (like a minor or docs change). |
Indeed. Trying to not to waste resources (electricity) at micro-scale may turn into significant saving. |
There's still a reviewer involved. Second guessing humans isn't helpful. Example: on a repo where I'm a maintainer I made an edit to a plan text file. I want to send it via a PR so it's visible to other maintainers that I'm making a change (pushing directly to master is considered bad form). But I don't need to trigger hours of CPU time worth of CI builds. I'm 99.99% sure I'm not breaking anything. And in the very unlikely case I did break something, I can just go back and fix it or revert the change. |
Surely if someone is just making a simple typo fix PR then it should be possible to avoid running 30-60 minutes' worth of tests? |
Most of the others CI use
[ci skip]
or[skip ci]
(e.g. Travis, CircleCI, Concourse, Codeship, Bitrise, Appveyor, GitlabCI)Some dependencies use
[ci skip]
as default to skip automatically versioning from their CI, why not make VSTS also accept it?The text was updated successfully, but these errors were encountered: