Update readme #109
Update readme #109
Conversation
satbai
force-pushed
the
users/satbai/updateReadme
branch
from
e555cad to
49adcb5
Compare
README.md
Outdated
|
|
||
| ### Automatic PowerShell installation: | ||
| Using the above is recommended, but as per [NuGet's plugin discovery rules](https://github.com/NuGet/Home/wiki/NuGet-Cross-Plat-Credential-Plugin#plugin-installation-and-discovery), alternatively you can install the credential provider to a location you prefer, and then set the environment variable NUGET_PLUGIN_PATHS to the .exe of the credential provider found in plugins\netfx\CredentialProvider.Microsoft\CredentialProvider.Microsoft.exe. For example, $env:NUGET_PLUGIN_PATHS="my-alternative-location\CredentialProvider.Microsoft.exe". |
There was a problem hiding this comment.
This will break dotnet (at least until NuGet/Home#8151 is fixed). Please update this guidance to make that clear.
There was a problem hiding this comment.
Thanks! I'll remove it from under dotnet and leave it for under nuget
There was a problem hiding this comment.
Hmm, nuget has the issue as well? Maybe I'll just add a link to the bug here. I'll think about this one.
There was a problem hiding this comment.
The "Linux and Mac" instructions below are perfectly fine, since dotnet is the only possibility there.
You don't need to remove it from here IMO, it should just indicate that setting the envvar to the .exe credprovider will break dotnet on windows, and setting the envvar to the .dll will break nuget.exe and MSBuild on windows.
There was a problem hiding this comment.
Therefore customers that use both dotnet and nuget.exe/MSBuild (.NET Framework) should probably avoid that envvar for now.
There was a problem hiding this comment.
I added "Note that if you are using both nuget and dotnet, this environment variable is not recommended due to this issue: NuGet/Home#8151"
There was a problem hiding this comment.
Looks good for the windows section, but is unnecessary for the linux/mac section (running nuget.exe and the .exe credprovider is not supported)
There was a problem hiding this comment.
Thanks. I guess I'm ready for the weekend.
satbai
force-pushed
the
users/satbai/updateReadme
branch
from
51c8204 to
d0829b7
Compare
README.md
Outdated
| @@ -88,6 +96,12 @@ msbuild /t:restore /p:nugetInteractive=true | |||
|
|
|||
| Once you've successfully acquired a token, you can run authenticated commands without the `/p:nugetInteractive=true` switch. | |||
|
|
|||
| ### unattended build agents | |||
satbai
force-pushed
the
users/satbai/updateReadme
branch
from
d0829b7 to
3fc3036
Compare
Making the readme better
#110
#89