Update build tools to latest version #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guperrot
previously requested changes
May 29, 2018
| @@ -2,7 +2,7 @@ apply plugin: 'com.android.library' | |||
|
|
|||
| android { | |||
| compileSdkVersion 23 | |||
| buildToolsVersion "23.0.1" | |||
| buildToolsVersion "27.0.3" | |||
|
there is an issue of npm install failing VSTS Build which seems to be same problem as https://github.com/npm/registry/issues/334. Please wait and retry. |
|
@bmourat Looks like facebook/react-native#19257 is bumping buildToolsVersion in React Native and it was already merged. Hopefully they will ship it soon. Though I don't think it will make a huge difference, I am inclined to bump the buildToolsVersion to 26.0.3 rather than 27.x.x. What do you think? |
|
Why using older build if we already tested that it does not impact apps, it's always recommended to have recent build tools that fixes bugs or improve perfs right? @dhei |
|
@guperrot Fair enough, I am fine with 27.x.x. |
dhei
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #318