Fix forms preview in our own apps #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works! However, the Push notification event did not fired if the app is killed. If the app is onsleep, this works. |
achocron
approved these changes
Mar 5, 2018
|
I'm sorry. Does this actually fix this issue?? I'm using Android Studio, is it worth plopping this into my project? |
|
@HAIDARCORP this is a Xamarin PR just to change the implementation of "avoid duplicate push event registration" in a way that does not break the previewer and is very specific to C#. Android Studio is for Java/Kotlin/C/C++ only and does not have duplicate issues in Java SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.