Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyscfParser: Add unit tests for parsing of FCIDUMP and CUBE files #24

Merged
merged 1 commit into from
Apr 7, 2023
Merged

PyscfParser: Add unit tests for parsing of FCIDUMP and CUBE files #24

merged 1 commit into from
Apr 7, 2023

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Apr 3, 2023

No description provided.

@sphuber sphuber force-pushed the feature/parser-tests branch from aea0182 to cdf6203 Compare April 3, 2023 12:16
@sphuber
Copy link
Contributor Author

sphuber commented Apr 3, 2023 •
edited
Loading

This is blocked because it requires additional functionality in aiida-core which should be added by aiidateam/aiida-core#5954

Actually, the fix was really in plumpy and that has been released in 0.21.4 which now gets automatically installed. So the tests now pass.

@sphuber sphuber force-pushed the feature/parser-tests branch from cdf6203 to 9c85b31 Compare April 4, 2023 09:49
@sphuber sphuber force-pushed the main branch 2 times, most recently from f4a28d9 to 6d223ad Compare April 5, 2023 21:34
@sphuber sphuber force-pushed the feature/parser-tests branch from 9c85b31 to 401279b Compare April 6, 2023 07:55
@sphuber sphuber force-pushed the feature/parser-tests branch from 401279b to b36f62d Compare April 6, 2023 19:41
@sphuber sphuber merged commit 017757c into main Apr 7, 2023
@sphuber sphuber deleted the feature/parser-tests branch April 7, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sphuber