Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target framework for .Net Core 3.1 #79

Merged
merged 3 commits into from
Oct 28, 2020

Conversation

punker76
Copy link
Contributor

Description of Change

This PR adds the target framework for .Net Core 3.1.

Bugs Fixed

Closes #78

API Changes

Added:

  • netcoreapp3.1 target framework

Behavioral Changes

-/-

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@ghost
Copy link

ghost commented Oct 21, 2020

CLA assistant check
All CLA requirements met.

@brianlagunas
Copy link
Collaborator

Hey @pedrolamas and @DVaughan, any idea why the build hasn't reported back? We can't merge until that process has been reported completed.

@pedrolamas
Copy link
Collaborator

No idea, I was thinking the same myself...

@DVaughan
Copy link
Contributor

It appears that the pipeline was not triggered. I don't know why not. Perhaps make an update and see if it is triggered.

@pedrolamas
Copy link
Collaborator

@punker76 can you please force-push (or make any other change) to your branch so we can check if the build pipeline starts as expected? Thank you!

@brianlagunas
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@punker76
Copy link
Contributor Author

@pedrolamas @DVaughan @brianlagunas I pushed a minor change, but it seems like the build pipeline doesn't like this PR. I can close this and try to create a new branch and PR...

@brianlagunas
Copy link
Collaborator

@DVaughan @pedrolamas Looks like we have an issue with the build server. Who can look into that?

@DVaughan
Copy link
Contributor

Currently looking into it.

@DVaughan
Copy link
Contributor

@punker76 would you please try that again. I've switched to a GitHub action and it's waiting for status. But, I'm hoping it will trigger the action with another commit.

@DVaughan
Copy link
Contributor

I've verified the build locally for this PR. I think the PR might need to be recreated for the action to trigger, so I'm merging without the status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to .Net Core 3.1
4 participants