Bug 55435589: MrtCore build now fails due to mrt.gdnsuppress exclusions not being found, due to case sensitive of nuget package cache #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alexlamtest
changed the title
Scottj1s
reviewed
Dec 10, 2024
| @@ -86,6 +86,7 @@ extends: | |||
| binskim: | |||
| enabled: true | |||
| break: true | |||
| analyzeTargetGlob: +:f|**.exe;+:f|**.dll;-:f|**\packages\**\*.dll;-:f|**\packages\**\*.exe | |||
There was a problem hiding this comment.
Ironic that analyzeTargetGlob is itself case-insensitive!
godlytalias
pushed a commit
that referenced
this pull request
Dec 13, 2024
…ns not being found, due to case sensitive of nuget package cache (#4951) * Snapshot 1 * Update WindowsAppSDK-Foundation-Nightly.yml * Update WindowsAppSDK-Foundation-Official.yml * Update WindowsAppSDK-Foundation-PR.yml
codendone
pushed a commit
that referenced
this pull request
Jan 10, 2025
…ns not being found, due to case sensitive of nuget package cache (#4951) * Snapshot 1 * Update WindowsAppSDK-Foundation-Nightly.yml * Update WindowsAppSDK-Foundation-Official.yml * Update WindowsAppSDK-Foundation-PR.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Packages folder contain binaries that are from external sources.
We've applied the policy of "each repo should focus on scanning its own binaries" to most other repos, so adding exclusion of the Packages folder to skip BinSkim scans on the Foundation repo.
How verified:
/////
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.