Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CameraCaptureUI Spec Doc #4895

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Updating CameraCaptureUI Spec Doc #4895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf6fe2f
Addressing comments from PR-review!
Saharsh979 Nov 18, 2024
0833338
addressing comments
Saharsh979 Nov 18, 2024
5ea2666
Addressing comment
Saharsh979 Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions specs/CameraCaptureUI/CameraCaptureUI.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,12 @@ Provides settings for capturing photos with CameraCaptureUI.
The settings include aspect ratio, image size, format, resolution,
and whether or not cropping is allowed by the user interface (UI).

**Important Note**:
- By default, `AllowCropping` is true.
- Don't specify both size and aspect ratio in the `PhotoSettings`, doing so will cause an invalid argument exception.
- `PhotoSettings` can't have a ratio or size specified with cropping disabled. Attempting to do so will result in an invalid argument exception.
Saharsh979 marked this conversation as resolved.
Show resolved Hide resolved


## CameraCaptureUIPhotoCaptureSettings Properties

| Name | Description | Value |
Expand All @@ -207,6 +213,12 @@ and whether or not cropping is allowed by the user interface (UI).
Provides settings for capturing videos.
The settings include format, maximum resolution, maximum duration, and whether or not to allow trimming.

**Important Note**:
- By default, `AllowTrimming` is true.
- `MaxDurationInSeconds` must be a valid value (i.e., the duration should be in the range of 0 to `UINT32_MAX`). Specifying an invalid value will result in an invalid argument exception.
- `MaxDurationInSeconds` cannot be set if `AllowTrimming` is false. Attempting to do so will result in an invalid argument exception.


## CameraCaptureUIVideoCaptureSettings Properties
| Name | Description | Value |
|-|-|-|
Expand Down Expand Up @@ -355,8 +367,6 @@ namespace Microsoft.Windows.Media.Capture
}

[contract(CameraCaptureUIContract, 1)]
[threading(sta),
marshaling_behavior(none)]
runtimeclass CameraCaptureUI
{
CameraCaptureUI(Microsoft.UI.WindowId window);
Expand Down
1 change: 1 addition & 0 deletions specs/WinRT/WinRTAPIContracts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ The list of all contracts defined across Windows App SDK
| AppLifecycle | windowsappsdk | AppLifecycleContract | Microsoft.Windows.AppLifecycle | |
| AppNotifications | windowsappsdk | AppNotificationsContract | Microsoft.Windows.AppNotifications | |
| BackgroundTask | windowsappsdk | BackgroundTaskContract | Microsoft.Windows.ApplicationModel.Background | |
| CameraCaptureUI | windowsappsdk | CameraCaptureUIContract | Microsoft.Windows.Media.Capture | |
| Deployment | windowsappsdk | DeploymentManagerContract | Microsoft.Windows.ApplicationModel.WindowsAppRuntime | |
| DynamicDependency | windowsappsdk | DynamicDependencyContract | Microsoft.Windows.ApplicationModel.DynamicDependency | |
| EnvironmentManager | windowsappsdk | EnvironmentManagerContract | Microsoft.Windows.System | |
Expand Down