-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WindowsAppSDK-RunHelixTests-Job.yml #3495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
codendone
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexlamtest
added a commit
that referenced
this pull request
Mar 15, 2023
* Update WindowsAppSDK-RunHelixTests-Job.yml * Update WindowsAppSDK-BuildFoundation-job.yml * Add files via upload * Update MrtCoreUnpackagedTests.csproj * Add files via upload * Update MrmUnitTest.vcxproj * Add files via upload * Update MrmBaseUnitTests.vcxproj * Update WindowsAppSDK-BuildFoundation-job.yml * Update WindowsAppSDK-RunHelixTests-Job.yml * Update WindowsAppSDK-RunTestsInPipeline-Job.yml * Update WindowsAppSDK-RunHelixTests-Job.yml * Update WindowsAppSDK-BuildFoundation-job.yml * Update MrmUnitTests.testdef * Update MrtCoreUnpackagedTests.testdef * Update MrmBaseUnitTests.testdef * Update WindowsAppSDK-BuildFoundation-job.yml * Update WindowsAppSDK-RunTestsInPipeline-Job.yml * Update tsaoptions.json * Update WindowsAppSDK-BuildAndTestMRT-Steps.yml * Delete MrmUnitTests.testdef * Add files via upload * Update MrmUnitTest.vcxproj * Update WindowsAppSDK-BuildAndTestMRT-Steps.yml * Update WindowsAppSDK-BuildFoundation-job.yml * Update WindowsAppSDK-BuildFoundation-job.yml * Update WindowsAppSDK-RunTestsInPipeline-Job.yml * Delete WindowsAppSDK-RunHelixTests-Job.yml * Update tsaoptions.json * Update ProjectReunion-CI.yml * Delete RunTestsInHelix.proj * Delete global.json * Delete packages.config * Delete WindowsAppSDK.Helix.Test.sln * Delete Program.cs * Delete WindowsAppSDK.Helix.Test.NetCore.csproj * Delete TestAssembly.cs * Delete TestMachineSetup.cmd * Delete TestPass-EnsureMachineState.ps1 * Delete TestPass-OneTimeMachineSetup.ps1 * Delete TestPass-PostRun.ps1 * Delete TestPass-PreRun.ps1 * Delete WindowsAppSDK.Helix.TestCommon.csproj * Update WindowsAppSDK-BuildAndTestMRT-Steps.yml
alexlamtest
added a commit
that referenced
this pull request
Mar 16, 2023
* Update WindowsAppSDK-RunHelixTests-Job.yml (#3495) * Update WindowsAppSDK-RunHelixTests-Job.yml * Update WindowsAppSDK-BuildFoundation-job.yml * Add files via upload * Update MrtCoreUnpackagedTests.csproj * Add files via upload * Update MrmUnitTest.vcxproj * Add files via upload * Update MrmBaseUnitTests.vcxproj * Update WindowsAppSDK-BuildFoundation-job.yml * Update WindowsAppSDK-RunHelixTests-Job.yml * Update WindowsAppSDK-RunTestsInPipeline-Job.yml * Update WindowsAppSDK-RunHelixTests-Job.yml * Update WindowsAppSDK-BuildFoundation-job.yml * Update MrmUnitTests.testdef * Update MrtCoreUnpackagedTests.testdef * Update MrmBaseUnitTests.testdef * Update WindowsAppSDK-BuildFoundation-job.yml * Update WindowsAppSDK-RunTestsInPipeline-Job.yml * Update tsaoptions.json * Update WindowsAppSDK-BuildAndTestMRT-Steps.yml * Delete MrmUnitTests.testdef * Add files via upload * Update MrmUnitTest.vcxproj * Update WindowsAppSDK-BuildAndTestMRT-Steps.yml * Update WindowsAppSDK-BuildFoundation-job.yml * Update WindowsAppSDK-BuildFoundation-job.yml * Update WindowsAppSDK-RunTestsInPipeline-Job.yml * Delete WindowsAppSDK-RunHelixTests-Job.yml * Update tsaoptions.json * Update ProjectReunion-CI.yml * Delete RunTestsInHelix.proj * Delete global.json * Delete packages.config * Delete WindowsAppSDK.Helix.Test.sln * Delete Program.cs * Delete WindowsAppSDK.Helix.Test.NetCore.csproj * Delete TestAssembly.cs * Delete TestMachineSetup.cmd * Delete TestPass-EnsureMachineState.ps1 * Delete TestPass-OneTimeMachineSetup.ps1 * Delete TestPass-PostRun.ps1 * Delete TestPass-PreRun.ps1 * Delete WindowsAppSDK.Helix.TestCommon.csproj * Update WindowsAppSDK-BuildAndTestMRT-Steps.yml * 43277347: Manaully apply some changes in the CP to a source file that diverged between the 1.3-stable and Develop branches. --------- Co-authored-by: Alex Lam (APPX) <alexlam@ntdev.microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated MRT's MrmBaseUnitTests, MrmUnitTest, and MrtCoreUnpackagedTests test suites from Helix to the pipeline test environment, leveraging the recently introduced .testdef mechanism for onboarding them. There is then no longer a need for WindowsAppSDK-RunHelixTests-job.yml, hence it is deleted in this PR.
Those 3 test suites were also being directly run on the current build job agent via the vstest task. That looks redundant now in the general case, because in the pipeline environment all TAEF tests are being run on many OS images, instead of just one version of Server. Hence, WindowsAppSDK-BuildAndTestMRT-Steps.yml is updated to stop running the 3 MRT test suites, unless the code is called from the CI pipeline, because in this specific flow we currently don't run any tests later in the 1ES hosted pipeline environment.
This PR not only allows us to drop dependency on Helix (whose support is dwindling) from the Foundation repo, but also makes the pipeline more efficient, e.g., in a sample pipeline run in the past: https://dev.azure.com/microsoft/ProjectReunion/_build/results?buildId=64221252&view=results, the "TestInHelix Release_x64" job that runs the MRT tests took 25m 23s.
In an early pipeline run of this PR: https://dev.azure.com/microsoft/ProjectReunion/_build/results?buildId=66122428&view=results, the "PipelineTestsX64 rs_prerelease_x64fre" that runs the same MRT suites, plus a couple of other pre-existing test suites there, took 12m 59s, i.e., a speed up of ~50%.
CR: Michael, Will, Robert
How built:
How Tested:
Summary: Total=268, Passed=268, Failed=0, Blocked=0, Not Run=0, Skipped=0
Summary: Total=21, Passed=21, Failed=0, Blocked=0, Not Run=0, Skipped=0
Summary: Total=27, Passed=27, Failed=0, Blocked=0, Not Run=0, Skipped=0
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the develop branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.
For status checks on the main branch, please use microsoft.ProjectReunion
(https://dev.azure.com/ms/ProjectReunion/_build?definitionId=391&_a=summary)
and run the build against your PR branch with the default parameters.