Fix issues in UndockedRegFreeWinRT auto-initializer and support for Self-contained #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix bad filename * No precompiledheaders when compiling the auto-initializer
…initialization support (#2493)
…rned a failing HRESULT (only trapped thrown exceptions, but the implementation does both) (#2498)
* Remove the 'if (Assembly.GetEntryAssembly() != Assembly.GetExecutingAssembly()) { return; }' shortcircuit as it catches loading for reflection AND for common test cases e.g. 'te.exe foo.dll' as auto-initialization isn't restricted to exes (i.e. it gets compiled into foo.dll) and then Entry!=Executing. Revert this for now and restore later when #2456 is addressed (by restrcting auto-init to only compile into exes)
* Fix typo
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sachintaMSFT
changed the title
kythant
approved these changes
May 12, 2022
sachintaMSFT
deleted the
user/sachinta/UrfwSupportForSelfContainedAndAutoInitialization-on-release-1.1-stable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking all fixes by @DrusTheAxe to get UndockedRegFreeWinRT auto-initializer and support for self-contained working, into 1.1-stable.