Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Microsoft.Windows.ApplicationModel.Resources.dll binary size by 70KB by disabling RTTI. #1468

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

jefgen
Copy link
Member

@jefgen jefgen commented Sep 22, 2021

MRT Core doesn't use RTTI, but the *.vcxproj file that is used for building Microsoft.Windows.ApplicationModel.Resources.dll doesn't explicitly disable it -- and it is enabled by default. We can turn it off, which saves ~70 KB.

File Size Before Size After
Microsoft.Windows.ApplicationModel.Resources.dll 178,688 107,520

Delta = -71,168 bytes (69.5 KB)

Note: I already disabled it for MRM.dll in the PR here: #904, which saved 37 KB.

MRT Core doesn't use RTTI, so we can turn it off, which saves ~70 KB.
@jefgen
Copy link
Member Author

jefgen commented Sep 22, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@rohanp-msft rohanp-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big improvement! Thanks!

@jefgen jefgen merged commit 660dd38 into main Sep 22, 2021
@jefgen jefgen deleted the user/jefgen/mrt-core-RTTI branch September 22, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants