Re-add lock file, fix build breaks #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "ncp": "^2.0.0", | ||
| "npm-font-open-sans": "^1.1.0", | ||
| "office-ui-fabric-react": "^6.40.0", | ||
| "react": "^16.5.2", | ||
| "react-app-rewired": "^1.5.2", | ||
| "react-app-rewired": "^2.1.5", |
There was a problem hiding this comment.
Please use the lower version of react-app-rewired because of this timarney/react-app-rewired#358. Or you can leave this, I can chnage this in my PR.
| const message = typeof error === 'string' ? error : (`${error.stack ? `${error.stack}: ` : ''}${error.message}`); | ||
| log.error(message) | ||
| private logError = (error: string | Error | Error[]) => { | ||
| const toString = (error: string | Error) => typeof error === 'string' ? error : (`${error.stack ? `${error.stack}: ` : ''}${error.message}`); |
There was a problem hiding this comment.
TSLint would complain shadowing variable here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds were failing after the lockfile was deleted by accident and some transitive dependencies were updated. It was deleted a long time ago (before WinML Dashboard was moved to this repo - it's available in the internal WindowsAI repo history only).
babel-minify is failing to minify Netron with a stack depth limit reached. I don't know if it's a bug in babel-minify with some infinite recursion, or the Netron source is too large for it to handle. Since the dashboard is low priority and not in my taskboard, I simply disabled minifying Netron for now, which adds a few hundred kilobytes to the build. We can investigate this later.
Since I was adjusting the packages and fixing build breaks I also updated the packages in package.json, which were quite outdated.