Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up infrastructure for wingetcreate #1755

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

ldennington
Copy link
Collaborator

Overview

This change sets up the infrastructure for VFS for Git to support deployments to microsoft/winget-pkgs via wingetcreate. Specifically:

  1. We update the VFS for Git inno installer metadata to be correct/compatible with wingetcreate
  2. We update the release-winget workflow to run on Windows Server instead of Ubuntu (required since wingetcreate is a Windows executable).

I also added quotes to appropriate paths to support spaces when compiling.

Testing

I tested this change with the following steps:

  1. Build a local copy of the installer
  2. Publish the locally-built copy as a faux pre-release
  3. Run wingetcreate new against the faux pre-release
  4. Verify generated manifests align with specifications in #700

Associated work items

#699
#700

Updating necessary files to support spaces in paths when compiling VFS for
Git.
Updating inno installer metadata to align with the specification
outlined in github/git-fundamentals#700.
`wingetcreate` is a Windows exe and thus must be run on Windows. Updating
our release-winget workflow accordingly.
Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad you did this work while it was fresh in your mind. Let's hope we never need to use it. ;)

@ldennington ldennington merged commit 8748fc2 into microsoft:master Oct 13, 2021
@vdye vdye mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants