Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make delete docs more verbose. #1689

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Make delete docs more verbose. #1689

merged 2 commits into from
Aug 12, 2020

Conversation

kyle-rader
Copy link
Contributor

Potential issues

  • Some folks reading the delete instructions might not know the best way to clean up after un-mounting.
  • They might expect un-mounting to also do this when it doesn't.

Added an explicit step for removing and added warning not to try deleting before un-mounting.

@kyle-rader kyle-rader changed the title Make Delete Docs more verbose Make delete docs more verbose. Aug 10, 2020
derrickstolee
derrickstolee approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Definitely an improvement and I only have a slight reorg comment.

docs/troubleshooting.md Outdated Show resolved Hide resolved
@kyle-rader
Copy link
Contributor Author

@derrickstolee seems one of the CI was cancelled for a timeout maybe? Or the agent machine was restarting? I don't think I have perms to request it re-run but feel free to force merge this if you are comfortable, otherwise, somehow re-queue the CI?

@derrickstolee
Copy link
Contributor

/azp run PR - Windows - Functional Tests (Sparse Mode)

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kyle-rader kyle-rader merged commit 0eeb14b into microsoft:master Aug 12, 2020
@kyle-rader kyle-rader deleted the user/kyrader/delete-docs branch August 12, 2020 16:50
@derrickstolee derrickstolee mentioned this pull request Oct 20, 2020
Merged
derrickstolee added a commit that referenced this pull request Oct 20, 2020
@derrickstolee
Merge pull request #1699: [Release] Milestone M178
4043e5c 
Here are the changes since our last release:

* #1689: Make delete docs more verbose
* #1697: Fix functional tests to skip around ProjFS issue
* #1694: Update Git to v2.29.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrickstolee derrickstolee derrickstolee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-rader @derrickstolee