Removed Diagnostics from sys.ts in order to avoid cyclical build dependency #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndency. Specifically, processDiagnosticMessages.ts was dependent on sys.ts, which was dependent on the rest of the compiler, which meant that in a broken state of diagnostics, you could never compile processDiagnosticMessages.ts.
| @@ -27,6 +27,10 @@ declare var module: any; | |||
| declare var process: any; | |||
| declare var global: any; | |||
|
|
|||
| enum SystemError { | |||
There was a problem hiding this comment.
i would just make it a constant. we do not have other ones now, so no need to use an enum. I would even make it "-2147024809", just give it a name.
There was a problem hiding this comment.
unsupportedFileEncodingErrorCode or something.
DanielRosenwasser
force-pushed
the
breakCycleInDiagnosticGeneration
branch
from
3c1d859 to
b371b02
Compare
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Oct 22, 2014
Removed Diagnostics from sys.ts in order to avoid cyclical build dependency
|
Thanks @sheetalkamat - and I'll openly say you were right about this. 😄 |
DanielRosenwasser
added a commit
that referenced
this pull request
Oct 23, 2014
Addresses the original intention of #932.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, processDiagnosticMessages.ts was dependent on sys.ts, which was dependent on the rest of the compiler, which meant that after merge, you could never compile processDiagnosticMessages.ts.