Skip to content

Emit 'Promise' decorator metadata return type for async methods #9156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Jun 14, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jun 14, 2016

Fixes #8351

emitSerializedTypeNode((<FunctionLikeDeclaration>node).type);
return;
if (node && isFunctionLike(node)) {
const fn = <FunctionLikeDeclaration>node;
Copy link
Contributor

@yuit yuit Jun 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you inline this instead? I don't think there is a need to create another variable declaration

@yuit
Copy link
Contributor

yuit commented Jun 14, 2016

👍

@ghost ghost merged commit c33df01 into master Jun 14, 2016
@ghost ghost deleted the decorator_metadata_async branch June 14, 2016 15:14
yuit pushed a commit that referenced this pull request Jun 14, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants