Disable conditional exports fallbacks on null values
#62483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@typescript-bot test top400 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes handling of conditional exports when they map to null values by disabling fallback resolution behavior. The fix prevents TypeScript from continuing to search for modules when a package explicitly maps an export to null, which indicates the export is intentionally disabled.
Key changes:
- Modified module resolution logic to respect
nullexport mappings and stop fallback attempts - Updated tracing behavior to only log "Resolved under condition" when a non-null value is found
- Added comprehensive test coverage for various module resolution strategies
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/cases/conformance/moduleResolution/conditionalExportsResolutionFallbackNull.ts | Test case demonstrating the fix with a package that maps "import" to null |
| tests/baselines/reference/*.trace.json | Expected trace outputs showing module resolution stops at null mapping |
| tests/baselines/reference/*.errors.txt | Expected error outputs confirming module not found |
| src/compiler/moduleNameResolver.ts | Core fix to prevent fallback resolution on null mappings |
|
@andrewbranch Here are the results of running the top 400 repos with tsc comparing Everything looks good! |
typescript-bot
added
For Backlog Bug
RyanCavanaugh
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62439
Less ambitious version of #62310