Lookup non-local element factory for reference marking when marking fragment references #60684

weswigham · 2024-12-04T21:18:47Z

In addition to the local name.

…ragment references in addition to local

weswigham · 2024-12-04T21:18:59Z

typescript-bot · 2024-12-04T21:19:05Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started
`user test this`	✅ Started
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

jakebailey · 2024-12-04T21:24:20Z

@typescript-bot test top400
@typescript-bot user test this

Rerunning this because I forgot to actually merge my fix before the last rerun 😅

typescript-bot · 2024-12-04T21:24:25Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started
`user test this`	✅ Started

typescript-bot · 2024-12-04T21:40:57Z

Hey @weswigham, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-12-04T22:02:17Z

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,048k (± 0.01%)}	_{194,263k (± 0.97%)}	_~	_192,998k	_196,717k	_{p=0.471 n=6}
_{Parse Time}	_{1.31s (± 0.68%)}	_{1.31s (± 0.75%)}	_~	_1.29s	_1.32s	_{p=0.931 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.76s (± 0.44%)}	_{9.76s (± 0.45%)}	_~	_9.68s	_9.81s	_{p=0.574 n=6}
_{Emit Time}	_{2.74s (± 0.64%)}	_{2.72s (± 0.94%)}	_~	_2.67s	_2.74s	_{p=0.086 n=6}
_{Total Time}	_{14.53s (± 0.41%)}	_{14.50s (± 0.19%)}	_~	_14.45s	_14.53s	_{p=0.572 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,226,014k (± 0.00%)}	_{1,225,994k (± 0.00%)}	_~	_1,225,980k	_1,226,023k	_{p=0.173 n=6}
_{Parse Time}	_{6.62s (± 0.50%)}	_{6.67s (± 1.05%)}	_~	_6.59s	_6.74s	_{p=0.377 n=6}
_{Bind Time}	_{1.88s (± 0.43%)}	_{1.89s (± 0.22%)}	_~	_1.88s	_1.89s	_{p=0.248 n=6}
_{Check Time}	_{31.98s (± 0.26%)}	_{31.93s (± 0.35%)}	_~	_31.81s	_32.10s	_{p=0.520 n=6}
_{Emit Time}	_{15.18s (± 0.27%)}	_{15.15s (± 0.24%)}	_~	_15.10s	_15.20s	_{p=0.334 n=6}
_{Total Time}	_{55.66s (± 0.17%)}	_{55.64s (± 0.26%)}	_~	_55.48s	_55.82s	_{p=0.686 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,501,823	_2,501,823	_~	_~	_~	_{p=1.000 n=6}
_Types	_909,645	_909,645	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,319,273k (± 0.00%)}	_{2,319,270k (± 0.00%)}	_~	_2,319,237k	_2,319,305k	_{p=1.000 n=6}
_{Parse Time}	_{9.32s (± 0.24%)}	_{9.30s (± 0.23%)}	_~	_9.28s	_9.33s	_{p=0.195 n=6}
_{Bind Time}	_{2.16s (± 0.77%)}	_{2.16s (± 0.68%)}	_~	_2.14s	_2.18s	_{p=0.934 n=6}
_{Check Time}	_{74.71s (± 0.37%)}	_{74.70s (± 0.56%)}	_~	_74.25s	_75.30s	_{p=1.000 n=6}
_{Emit Time}	_{0.29s (± 3.41%)}	_{0.28s (± 2.70%)}	_~	_0.27s	_0.29s	_{p=0.102 n=6}
_{Total Time}	_{86.47s (± 0.33%)}	_{86.44s (± 0.51%)}	_~	_85.98s	_87.07s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,287	_1,225,288	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,555	_266,555	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,414,743k (± 6.15%)}	_{2,354,404k (± 0.03%)}	_~	_2,353,853k	_2,355,557k	_{p=0.810 n=6}
_{Parse Time}	_{5.25s (± 0.74%)}	_{5.23s (± 0.61%)}	_~	_5.19s	_5.27s	_{p=0.336 n=6}
_{Bind Time}	_{1.77s (± 1.37%)}	_{1.78s (± 0.71%)}	_~	_1.76s	_1.79s	_{p=0.249 n=6}
_{Check Time}	_{35.21s (± 0.81%)}	_{35.22s (± 0.20%)}	_~	_35.14s	_35.30s	_{p=0.575 n=6}
_{Emit Time}	_{2.97s (± 1.06%)}	_{2.96s (± 2.11%)}	_~	_2.85s	_3.02s	_{p=0.936 n=6}
_{Total Time}	_{45.23s (± 0.57%)}	_{45.18s (± 0.28%)}	_~	_45.04s	_45.33s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,287	_1,225,288	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,555	_266,555	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,907,852k (±12.87%)}	_{3,150,106k (± 0.03%)}	_~	_3,148,832k	_3,151,008k	_{p=0.093 n=6}
_{Parse Time}	_{6.94s (± 1.91%)}	_{7.00s (± 0.70%)}	_~	_6.93s	_7.08s	_{p=0.936 n=6}
_{Bind Time}	_{2.18s (± 1.85%)}	_{2.15s (± 1.81%)}	_~	_2.10s	_2.21s	_{p=0.335 n=6}
_{Check Time}	_{42.74s (± 0.37%)}	_{42.81s (± 0.45%)}	_~	_42.51s	_43.04s	_{p=0.471 n=6}
_{Emit Time}	_{3.45s (± 2.28%)}	_{3.51s (± 1.13%)}	_~	_3.44s	_3.56s	_{p=0.148 n=6}
_{Total Time}	_{55.31s (± 0.49%)}	_{55.47s (± 0.37%)}	_~	_55.21s	_55.77s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,259	_262,260	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,616	_106,616	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{439,869k (± 0.01%)}	_{439,876k (± 0.01%)}	_~	_439,820k	_439,897k	_{p=0.575 n=6}
_{Parse Time}	_{3.54s (± 0.45%)}	_{3.52s (± 0.92%)}	_~	_3.49s	_3.58s	_{p=0.063 n=6}
_{Bind Time}	_{1.33s (± 0.88%)}	_{1.33s (± 1.06%)}	_~	_1.31s	_1.35s	_{p=0.803 n=6}
_{Check Time}	_{18.98s (± 0.41%)}	_{18.96s (± 0.11%)}	_~	_18.94s	_19.00s	_{p=0.808 n=6}
_{Emit Time}	_{1.51s (± 1.08%)}	_{1.53s (± 1.07%)}	_~	_1.50s	_1.55s	_{p=0.193 n=6}
_{Total Time}	_{25.36s (± 0.31%)}	_{25.34s (± 0.14%)}	_~	_25.30s	_25.39s	_{p=0.935 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,675k (± 0.04%)}	_{371,553k (± 0.01%)}	_{-122k (- 0.03%)}	_371,509k	_371,622k	_{p=0.037 n=6}
_{Parse Time}	_{2.91s (± 1.03%)}	_{2.91s (± 1.51%)}	_~	_2.85s	_2.96s	_{p=0.936 n=6}
_{Bind Time}	_{1.59s (± 1.01%)}	_{1.59s (± 0.89%)}	_~	_1.57s	_1.61s	_{p=1.000 n=6}
_{Check Time}	_{16.51s (± 0.55%)}	_{16.51s (± 0.26%)}	_~	_16.46s	_16.56s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{21.02s (± 0.39%)}	_{21.01s (± 0.07%)}	_~	_20.99s	_21.03s	_{p=0.573 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,197,681	_3,197,681	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,099,171	_1,099,171	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,271,738k (± 0.03%)}	_{3,271,593k (± 0.01%)}	_~	_3,270,907k	_3,272,159k	_{p=1.000 n=6}
_{Parse Time}	_{14.05s (± 0.40%)}	_{14.00s (± 0.58%)}	_~	_13.91s	_14.10s	_{p=0.335 n=6}
_{Bind Time}	_{4.47s (± 0.36%)}	_{4.48s (± 0.51%)}	_~	_4.45s	_4.51s	_{p=0.685 n=6}
_{Check Time}	_{86.94s (± 2.29%)}	_{87.52s (± 3.08%)}	_~	_84.64s	_91.95s	_{p=0.471 n=6}
_{Emit Time}	_{28.05s (± 2.84%)}	_{26.95s (± 8.00%)}	_~	_22.81s	_28.91s	_{p=0.378 n=6}
_{Total Time}	_{133.53s (± 1.00%)}	_{132.96s (± 1.93%)}	_~	_130.35s	_137.52s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,751	_288,751	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,157	_117,157	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,076k (± 0.04%)}	_{441,093k (± 0.03%)}	_~	_440,832k	_441,213k	_{p=0.936 n=6}
_{Parse Time}	_{4.08s (± 1.16%)}	_{4.10s (± 1.84%)}	_~	_3.98s	_4.20s	_{p=0.520 n=6}
_{Bind Time}	_{1.76s (± 1.11%)}	_{1.77s (± 1.21%)}	_~	_1.73s	_1.79s	_{p=0.739 n=6}
_{Check Time}	_{18.88s (± 0.46%)}	_{18.94s (± 0.19%)}	_~	_18.89s	_18.99s	_{p=0.419 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.73s (± 0.35%)}	_{24.80s (± 0.34%)}	_~	_24.70s	_24.91s	_{p=0.148 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_552,390	_552,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_185,096	_185,096	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{492,524k (± 0.01%)}	_{492,451k (± 0.03%)}	_~	_492,178k	_492,546k	_{p=0.173 n=6}
_{Parse Time}	_{3.43s (± 0.40%)}	_{3.41s (± 1.01%)}	_~	_3.36s	_3.46s	_{p=0.168 n=6}
_{Bind Time}	_{1.17s (± 1.00%)}	_{1.18s (± 1.48%)}	_~	_1.16s	_1.21s	_{p=0.251 n=6}
_{Check Time}	_{19.52s (± 0.89%)}	_{19.69s (± 2.92%)}	_~	_19.37s	_20.86s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{24.12s (± 0.68%)}	_{24.28s (± 2.40%)}	_~	_23.95s	_25.46s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-12-04T22:55:35Z

@typescript-bot test top400
@typescript-bot user test this

typescript-bot · 2024-12-04T22:55:40Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results

typescript-bot · 2024-12-04T23:18:39Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60684/merge:

Everything looks good!

typescript-bot · 2024-12-05T00:25:03Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60684/merge:

Everything looks good!

Lookup non-local element factory for reference marking when marking f…

254293b

…ragment references in addition to local

weswigham requested review from sandersn and iisaduan December 4, 2024 21:18

typescript-bot assigned weswigham Dec 4, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Dec 4, 2024

This comment was marked as outdated.

Sign in to view

iisaduan approved these changes Dec 4, 2024

View reviewed changes

weswigham merged commit 12d9687 into microsoft:main Dec 5, 2024
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lookup non-local element factory for reference marking when marking fragment references #60684

Lookup non-local element factory for reference marking when marking fragment references #60684

weswigham commented Dec 4, 2024

weswigham commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

jakebailey commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024

typescript-bot commented Dec 4, 2024

tsc

jakebailey commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024

typescript-bot commented Dec 5, 2024

Lookup non-local element factory for reference marking when marking fragment references #60684

Lookup non-local element factory for reference marking when marking fragment references #60684

Conversation

weswigham commented Dec 4, 2024

weswigham commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

jakebailey commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 • edited Loading

typescript-bot commented Dec 4, 2024

typescript-bot commented Dec 4, 2024

tsc

jakebailey commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 • edited Loading

typescript-bot commented Dec 4, 2024

typescript-bot commented Dec 5, 2024

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024 •

edited

Loading