Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require import attributes for JSON imports in --module node16 #60673

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Dec 3, 2024

Fixes #60589

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Dec 3, 2024
@andrewbranch
Copy link
Member Author

@typescript-bot cherry-pick this to release-5.7

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 3, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.7 ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

Hey, @andrewbranch! I've created #60674 for you.

@andrewbranch andrewbranch merged commit 9bf5aa7 into microsoft:main Dec 4, 2024
32 checks passed
@andrewbranch andrewbranch deleted the bug/60589 branch December 4, 2024 16:47
DanielRosenwasser pushed a commit that referenced this pull request Dec 4, 2024
…e-5.7 (#60674)

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Module resolution: Regression in JSON import using Node16 resolution
3 participants