Fix library inclusions for ES2024 target #60622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
petamoriken
reviewed
Nov 27, 2024
typescript-bot
added
For Milestone Bug
|
@microsoft-github-policy-service agree |
petamoriken
reviewed
Nov 28, 2024
Comment on lines
148
to
+151
| // NOTE: We must reevaluate the target for upcoming features when each successive TC39 edition is ratified in | ||
| // June of each year. This includes changes to `LanguageFeatureMinimumTarget`, `ScriptTarget`, | ||
| // `ScriptTargetFeatures` transformers/esnext.ts, compiler/commandLineParser.ts and the contents of each | ||
| // lib/esnext.*.d.ts file. | ||
| // `ScriptTargetFeatures` transformers/esnext.ts, compiler/commandLineParser.ts, | ||
| // compiler/utilitiesPublic.ts, and the contents of each lib/esnext.*.d.ts file. |
There was a problem hiding this comment.
@billyjanitsch Sorry for the lack of information 🙇
NOTE comments exist in multiple files and I would like to have them updated as well:
src/compiler/types.ts(two places)src/compiler/utilities.tssrc/compiler/transformers/esnext.ts
Also, please add these comments to src/compiler/utilitiesPublic.ts.
rbuckton
approved these changes
Dec 3, 2024
|
@DanielRosenwasser should we take this as part of a patch to 5.7 or leave it for 5.8? |
|
I definitely think we should backport this, given ES2024 is not functional without it. @typescript-bot cherry-pick this to release-5.7 |
typescript-bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
|
Hey, @jakebailey! I've created #60681 for you. This involved updating baselines; please check the diff. |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Dec 6, 2024
…e-5.7 (#60681) Co-authored-by: Billy Janitsch <billyjanitsch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60621.