Narrow generic conditional and indexed access return types when checking return statements, no conditional expression support #60268

gabritto · 2024-10-18T01:04:53Z

A version of #56941 without any of the extra stuff for checking conditional expressions.

…n statement

gabritto · 2024-10-18T01:05:04Z

typescript-bot · 2024-10-18T01:05:08Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-10-18T01:46:25Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,337	_{-3 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_50,379	_50,378	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{195,069k (± 0.92%)}	_{194,890k (± 1.00%)}	_~	_192,989k	_196,699k	_{p=0.378 n=6}
_{Parse Time}	_{1.32s (± 0.64%)}	_{1.30s (± 0.63%)}	_{-0.01s (- 0.89%)}	_1.29s	_1.31s	_{p=0.045 n=6}
_{Bind Time}	_0.72s	_{0.72s (± 0.57%)}	_~	_0.71s	_0.72s	_{p=0.405 n=6}
_{Check Time}	_{9.72s (± 0.73%)}	_{9.78s (± 0.26%)}	_~	_9.75s	_9.82s	_{p=0.107 n=6}
_{Emit Time}	_{2.75s (± 1.00%)}	_{2.73s (± 0.38%)}	_~	_2.72s	_2.75s	_{p=0.220 n=6}
_{Total Time}	_{14.50s (± 0.43%)}	_{14.54s (± 0.16%)}	_~	_14.51s	_14.58s	_{p=0.419 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,576	_{-310 (- 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,840	_410,700	_{-140 (- 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,224,815k (± 0.00%)}	_{1,225,876k (± 0.00%)}	_{+1,061k (+ 0.09%)}	_1,225,813k	_1,225,971k	_{p=0.005 n=6}
_{Parse Time}	_{8.04s (± 0.73%)}	_{8.12s (± 0.89%)}	_~	_8.02s	_8.23s	_{p=0.065 n=6}
_{Bind Time}	_{2.28s (± 0.66%)}	_{2.27s (± 1.23%)}	_~	_2.24s	_2.31s	_{p=0.745 n=6}
_{Check Time}	_{37.92s (± 0.31%)}	_{37.94s (± 0.29%)}	_~	_37.78s	_38.10s	_{p=0.809 n=6}
_{Emit Time}	_{18.33s (± 0.54%)}	_{18.31s (± 0.49%)}	_~	_18.19s	_18.44s	_{p=1.000 n=6}
_{Total Time}	_{66.56s (± 0.29%)}	_{66.64s (± 0.32%)}	_~	_66.26s	_66.86s	_{p=0.520 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,530,445	_2,484,344	_{-46,101 (- 1.82%)}	_~	_~	_{p=0.001 n=6}
_Types	_916,594	_914,759	_{-1,835 (- 0.20%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,342,014k (± 0.00%)}	_{2,332,708k (± 0.01%)}	_{-9,306k (- 0.40%)}	_2,332,469k	_2,332,962k	_{p=0.005 n=6}
_{Parse Time}	_{11.23s (± 0.52%)}	_{11.19s (± 0.54%)}	_~	_11.08s	_11.24s	_{p=0.229 n=6}
_{Bind Time}	_{2.63s (± 0.57%)}	_{2.62s (± 0.52%)}	_~	_2.61s	_2.64s	_{p=0.680 n=6}
_{Check Time}	_{90.94s (± 0.21%)}	_{90.50s (± 0.30%)}	_{-0.44s (- 0.48%)}	_89.98s	_90.75s	_{p=0.020 n=6}
_{Emit Time}	_{0.36s (± 2.35%)}	_{0.35s (± 2.14%)}	_~	_0.34s	_0.36s	_{p=0.652 n=6}
_{Total Time}	_{105.16s (± 0.21%)}	_{104.66s (± 0.27%)}	_{-0.50s (- 0.48%)}	_104.12s	_104.92s	_{p=0.016 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,032	_1,258,184	_{+152 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,259	_266,226	_{-33 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,146,643k (± 0.02%)}	_{3,150,265k (± 0.03%)}	_{+3,622k (+ 0.12%)}	_3,149,068k	_3,151,551k	_{p=0.005 n=6}
_{Parse Time}	_{6.62s (± 0.46%)}	_{6.56s (± 0.45%)}	_{-0.06s (- 0.88%)}	_6.52s	_6.61s	_{p=0.016 n=6}
_{Bind Time}	_{2.29s (± 4.46%)}	_{2.35s (± 1.00%)}	_~	_2.32s	_2.38s	_{p=0.108 n=6}
_{Check Time}	_{43.11s (± 0.46%)}	_{43.05s (± 0.20%)}	_~	_42.94s	_43.19s	_{p=0.748 n=6}
_{Emit Time}	_{3.47s (± 2.48%)}	_{3.54s (± 3.51%)}	_~	_3.31s	_3.64s	_{p=0.199 n=6}
_{Total Time}	_{55.48s (± 0.58%)}	_{55.52s (± 0.26%)}	_~	_55.30s	_55.68s	_{p=1.000 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,032	_1,258,184	_{+152 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,259	_266,226	_{-33 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,765,526k (±12.86%)}	_{2,742,220k (±13.57%)}	_~	_2,501,137k	_3,223,249k	_{p=0.378 n=6}
_{Parse Time}	_{8.33s (± 2.22%)}	_{8.26s (± 2.63%)}	_~	_8.06s	_8.59s	_{p=0.378 n=6}
_{Bind Time}	_{2.72s (± 4.99%)}	_{2.69s (± 3.77%)}	_~	_2.57s	_2.88s	_{p=1.000 n=6}
_{Check Time}	_{53.61s (± 0.85%)}	_{53.53s (± 0.26%)}	_~	_53.39s	_53.68s	_{p=0.810 n=6}
_{Emit Time}	_{4.40s (± 3.18%)}	_{4.34s (± 1.20%)}	_~	_4.27s	_4.39s	_{p=0.378 n=6}
_{Total Time}	_{69.05s (± 0.66%)}	_{68.82s (± 0.24%)}	_~	_68.65s	_69.10s	_{p=0.423 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,789	_262,141	_{+352 (+ 0.13%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,511	_106,574	_{+63 (+ 0.06%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{438,806k (± 0.01%)}	_{439,712k (± 0.02%)}	_{+906k (+ 0.21%)}	_439,551k	_439,792k	_{p=0.005 n=6}
_{Parse Time}	_{4.38s (± 1.05%)}	_{4.38s (± 0.37%)}	_~	_4.35s	_4.40s	_{p=0.627 n=6}
_{Bind Time}	_{1.61s (± 1.87%)}	_{1.62s (± 0.55%)}	_~	_1.61s	_1.63s	_{p=0.563 n=6}
_{Check Time}	_{23.41s (± 0.21%)}	_{23.40s (± 0.41%)}	_~	_23.30s	_23.55s	_{p=0.688 n=6}
_{Emit Time}	_{1.91s (± 0.97%)}	_{1.92s (± 1.45%)}	_~	_1.89s	_1.97s	_{p=0.935 n=6}
_{Total Time}	_{31.31s (± 0.31%)}	_{31.32s (± 0.30%)}	_~	_31.24s	_31.47s	_{p=0.936 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,912	_{-7 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_94,415	_94,413	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{371,082k (± 0.01%)}	_{371,473k (± 0.01%)}	_{+391k (+ 0.11%)}	_371,420k	_371,532k	_{p=0.005 n=6}
_{Parse Time}	_{2.90s (± 0.38%)}	_{2.90s (± 1.37%)}	_~	_2.87s	_2.96s	_{p=0.742 n=6}
_{Bind Time}	_{1.59s (± 1.34%)}	_{1.57s (± 0.94%)}	_~	_1.55s	_1.59s	_{p=0.120 n=6}
_{Check Time}	_{16.40s (± 0.47%)}	_{16.38s (± 0.15%)}	_~	_16.35s	_16.41s	_{p=0.374 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.89s (± 0.38%)}	_{20.85s (± 0.27%)}	_~	_20.79s	_20.93s	_{p=0.377 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,118,970	_3,116,203	_{-2,767 (- 0.09%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,075,058	_1,073,952	_{-1,106 (- 0.10%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,212,484k (± 0.01%)}	_{3,216,787k (± 0.01%)}	_{+4,304k (+ 0.13%)}	_3,215,965k	_3,217,084k	_{p=0.005 n=6}
_{Parse Time}	_{11.56s (± 0.28%)}	_{11.56s (± 0.12%)}	_~	_11.55s	_11.58s	_{p=0.459 n=6}
_{Bind Time}	_{3.70s (± 0.46%)}	_{3.69s (± 0.22%)}	_~	_3.68s	_3.70s	_{p=0.402 n=6}
_{Check Time}	_{72.20s (± 0.45%)}	_{72.31s (± 0.38%)}	_~	_71.97s	_72.72s	_{p=0.471 n=6}
_{Emit Time}	_{22.67s (± 0.70%)}	_{22.89s (± 1.91%)}	_~	_22.64s	_23.78s	_{p=0.378 n=6}
_{Total Time}	_{110.12s (± 0.44%)}	_{110.46s (± 0.48%)}	_~	_109.97s	_111.43s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_286,241	_286,097	_{-144 (- 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_116,005	_115,937	_{-68 (- 0.06%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{436,644k (± 0.02%)}	_{436,812k (± 0.02%)}	_{+168k (+ 0.04%)}	_436,698k	_436,900k	_{p=0.013 n=6}
_{Parse Time}	_{4.09s (± 0.95%)}	_{4.08s (± 1.06%)}	_~	_4.01s	_4.14s	_{p=0.629 n=6}
_{Bind Time}	_{1.74s (± 1.42%)}	_{1.75s (± 0.93%)}	_~	_1.73s	_1.77s	_{p=0.745 n=6}
_{Check Time}	_{18.44s (± 0.45%)}	_{18.48s (± 0.43%)}	_~	_18.41s	_18.59s	_{p=0.468 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.27s (± 0.34%)}	_{24.30s (± 0.30%)}	_~	_24.24s	_24.43s	_{p=0.688 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_543,130	_542,780	_{-350 (- 0.06%)}	_~	_~	_{p=0.001 n=6}
_Types	_181,889	_181,659	_{-230 (- 0.13%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{485,460k (± 0.02%)}	_{486,156k (± 0.02%)}	_{+696k (+ 0.14%)}	_486,053k	_486,324k	_{p=0.005 n=6}
_{Parse Time}	_{3.35s (± 0.81%)}	_{3.35s (± 0.53%)}	_~	_3.32s	_3.37s	_{p=0.513 n=6}
_{Bind Time}	_{1.18s (± 0.69%)}	_{1.17s (± 1.05%)}	_~	_1.15s	_1.18s	_{p=0.120 n=6}
_{Check Time}	_{19.31s (± 2.13%)}	_{19.13s (± 0.52%)}	_~	_18.99s	_19.25s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{23.84s (± 1.75%)}	_{23.64s (± 0.47%)}	_~	_23.50s	_23.78s	_{p=0.470 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,315ms (± 0.30%)}	_{2,321ms (± 0.31%)}	_~	_2,313ms	_2,331ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{5,297ms (± 0.43%)}	_{5,291ms (± 0.68%)}	_~	_5,240ms	_5,341ms	_{p=0.748 n=6}
_{Req 3 - references}	_{266ms (± 0.28%)}	_{263ms (± 0.68%)}	_{-3ms (- 1.19%)}	_261ms	_266ms	_{p=0.014 n=6}
_{Req 4 - navto}	_{227ms (± 0.37%)}	_{227ms (± 0.72%)}	_~	_224ms	_228ms	_{p=0.116 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{81ms (± 5.15%)}	_{82ms (± 6.14%)}	_~	_76ms	_91ms	_{p=0.685 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,442ms (± 1.10%)}	_{2,446ms (± 0.97%)}	_~	_2,410ms	_2,466ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{3,973ms (± 0.50%)}	_{3,968ms (± 0.16%)}	_~	_3,960ms	_3,977ms	_{p=0.810 n=6}
_{Req 3 - references}	_{282ms (± 1.08%)}	_{278ms (± 1.07%)}	_{-4ms (- 1.48%)}	_275ms	_283ms	_{p=0.043 n=6}
_{Req 4 - navto}	_{226ms (± 0.28%)}	_{235ms (± 2.78%)}	_{+9ms (+ 3.91%)}	_226ms	_240ms	_{p=0.019 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 6.32%)}	_{83ms (± 2.57%)}	_~	_81ms	_86ms	_{p=1.000 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,265ms (± 0.27%)}	_{5,270ms (± 0.27%)}	_~	_5,254ms	_5,295ms	_{p=0.335 n=6}
_{Req 2 - geterr}	_{1,139ms (± 0.79%)}	_{1,143ms (± 0.83%)}	_~	_1,130ms	_1,159ms	_{p=0.374 n=6}
_{Req 3 - references}	_{81ms (± 3.52%)}	_80ms	_~	_~	_~	_{p=0.405 n=6}
_{Req 4 - navto}	_{447ms (± 0.30%)}	_{444ms (± 1.34%)}	_~	_436ms	_448ms	_{p=0.557 n=6}
_{Req 5 - completionInfo count}	_3,450	_3,450	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{849ms (± 2.46%)}	_{853ms (± 0.46%)}	_~	_846ms	_857ms	_{p=0.377 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{183.96ms (± 0.21%)}	_{184.40ms (± 0.19%)}	_{+0.44ms (+ 0.24%)}	_182.10ms	_188.22ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{234.37ms (± 0.15%)}	_{234.57ms (± 0.16%)}	_{+0.19ms (+ 0.08%)}	_233.12ms	_241.80ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.63ms (± 0.14%)}	_{229.86ms (± 0.15%)}	_{+0.22ms (+ 0.10%)}	_228.36ms	_235.93ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.58ms (± 0.14%)}	_{228.72ms (± 0.15%)}	_{+0.14ms (+ 0.06%)}	_227.26ms	_232.96ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Andarist · 2024-11-30T11:51:08Z

@gabritto should this one perhaps be closed?

gabritto added 30 commits May 15, 2023 18:15

WIP: custom instantiation

0d393e3

fix more things

a1d9f89

latest fixes

b9495a9

Merge branch 'main' into gabritto/d2

81cdee5

fix bare type parameter instantiation

af57b34

change binder. BROKEN

01152a0

fix binder change

eac3192

clean up + tests

199ecd0

WIP

d0e85d0

Merge branch 'main' into gabritto/d2

23e3d33

defer conditional unless narrowing

d9ac102

don't skip jsdoc type assertions

b4910f4

more fixes

6258bc0

WIP: account for pre-existing mapping

de3428d

only narrow when we take a true branch of a conditional

04980d3

small fix + new tests

e60a625

fix optional parameter handling and shadowing

ee2d1ba

fix skip parentheses

b8ce490

fix updates to binder, cleanup in checker

2439767

Merge branch 'main' into gabritto/d2

3f504f4

HasFlowNode update & fixes

5e8ca3e

cleanup; always check conditional expression's condition inside retur…

534cc38

…n statement

update test after merging

1dc9ab5

maybe make binder change faster

a94bc23

don't narrow if conditional has infer type params

046b53c

don't walk up parents when binding conditional expression

5a83feb

add promise and generator tests

1ac4a58

get rid of cast

db219a3

add indexed access tests

56792a1

WIP

b292bd8

gabritto added 20 commits August 27, 2024 17:32

reuse instantiateType and other functions for narrowing instantiation

8a1417c

use substitution types

d74630c

refactoring

10403cf

switch reference detection algorithm

99d3cd5

refactor and add more tests

39d2f2b

remove unused

42f7a2d

Merge branch 'main' into gabritto/d2-detect

678d2e0

update baselines

7e1fe01

refactor and fix validation of conditional return type

bbaf88f

Merge branch 'main' into gabritto/d2-detect

a8200ec

fmt

47d8d3f

cache intermediate results for conditional validation

228148d

take mapper into consideration when validating conditional type

76718d8

refactor

20b79eb

don't skip jsdoc type assertions

3788ada

Merge branch 'main' into gabritto/d2-detect

2569804

experiment: always set flow node in cond expr

827962f

support jsdoc

4e77373

add more jsdoc tests

c076dda

remove support for conditional expressions

156d52b

typescript-bot assigned gabritto Oct 18, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 18, 2024

gabritto changed the title ~~Gabritto/d2 nocond~~ Narrow generic conditional and indexed access return types when checking return statements, no conditional expression support Oct 18, 2024

gabritto mentioned this pull request Oct 18, 2024

Narrow generic conditional and indexed access return types when checking return statements #56941

Merged

gabritto closed this Dec 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Narrow generic conditional and indexed access return types when checking return statements, no conditional expression support #60268

Narrow generic conditional and indexed access return types when checking return statements, no conditional expression support #60268

gabritto commented Oct 18, 2024 •

edited

Loading

gabritto commented Oct 18, 2024

typescript-bot commented Oct 18, 2024 •

edited

Loading

typescript-bot commented Oct 18, 2024

tsc

tsserver

startup

Andarist commented Nov 30, 2024

Narrow generic conditional and indexed access return types when checking return statements, no conditional expression support #60268

Narrow generic conditional and indexed access return types when checking return statements, no conditional expression support #60268

Conversation

gabritto commented Oct 18, 2024 • edited Loading

gabritto commented Oct 18, 2024

typescript-bot commented Oct 18, 2024 • edited Loading

typescript-bot commented Oct 18, 2024

tsc

tsserver

startup

Andarist commented Nov 30, 2024

gabritto commented Oct 18, 2024 •

edited

Loading

typescript-bot commented Oct 18, 2024 •

edited

Loading