Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include type-meaning 'extends' clause in auto-import fix list #59853

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

RyanCavanaugh
Copy link
Member

If you have something like

// In global or local scope
interface Foo {
}

// User is editing here
class Bar extends Foo { }
//                ~~~
// Cannot extend interface, did you mean implements?

// In another file
export class Foo { }

This error is potentially fixable with an auto-import, so should appear in the list of errors that trigger autoimports

Checked locally
image

Fixes #59842

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 4, 2024
@DanielRosenwasser
Copy link
Member

Seems right, can you just add a quick test case?

@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 4, 2024
@RyanCavanaugh RyanCavanaugh merged commit 4105134 into microsoft:main Dec 4, 2024
32 checks passed
@RyanCavanaugh RyanCavanaugh deleted the fix_59842 branch December 4, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cannot import Disposable
4 participants