Revert PR 55371 #58702

gabritto · 2024-05-29T18:42:17Z

gabritto · 2024-05-29T18:42:49Z

typescript-bot · 2024-05-29T18:42:53Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-05-29T19:05:17Z

Hey @gabritto, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-05-29T19:11:03Z

@gabritto Here are the results of running the user tests comparing main and refs/pull/58702/merge:

Everything looks good!

typescript-bot · 2024-05-29T19:18:14Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,871k (± 0.74%)}	_{193,059k (± 0.69%)}	_~	_192,259k	_195,764k	_{p=0.173 n=6}
_{Parse Time}	_{1.30s (± 0.80%)}	_{1.31s (± 1.04%)}	_~	_1.29s	_1.32s	_{p=0.804 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.54s (± 0.18%)}	_{9.54s (± 0.40%)}	_~	_9.49s	_9.60s	_{p=0.806 n=6}
_{Emit Time}	_{2.64s (± 0.50%)}	_{2.63s (± 0.65%)}	_~	_2.61s	_2.65s	_{p=0.286 n=6}
_{Total Time}	_{14.20s (± 0.24%)}	_{14.20s (± 0.39%)}	_~	_14.11s	_14.26s	_{p=1.000 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,105	_944,105	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,032	_407,032	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,105k (± 0.00%)}	_{1,222,106k (± 0.00%)}	_~	_1,222,060k	_1,222,146k	_{p=0.872 n=6}
_{Parse Time}	_{6.82s (± 0.74%)}	_{6.81s (± 0.77%)}	_~	_6.74s	_6.87s	_{p=1.000 n=6}
_{Bind Time}	_{1.88s (± 0.43%)}	_{1.88s (± 0.56%)}	_~	_1.86s	_1.89s	_{p=0.181 n=6}
_{Check Time}	_{31.39s (± 0.39%)}	_{31.28s (± 0.55%)}	_~	_31.05s	_31.54s	_{p=0.297 n=6}
_{Emit Time}	_{14.78s (± 0.20%)}	_{14.77s (± 0.28%)}	_~	_14.69s	_14.80s	_{p=1.000 n=6}
_{Total Time}	_{54.88s (± 0.25%)}	_{54.74s (± 0.33%)}	_~	_54.53s	_54.98s	_{p=0.230 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,053,011	_2,053,011	_~	_~	_~	_{p=1.000 n=6}
_Types	_899,367	_899,368	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,065,938k (± 0.01%)}	_{2,065,881k (± 0.01%)}	_~	_2,065,643k	_2,065,970k	_{p=0.128 n=6}
_{Parse Time}	_{8.11s (± 0.36%)}	_{8.10s (± 0.12%)}	_~	_8.09s	_8.11s	_{p=0.620 n=6}
_{Bind Time}	_{2.73s (± 0.46%)}	_{2.74s (± 1.02%)}	_~	_2.72s	_2.78s	_{p=0.452 n=6}
_{Check Time}	_{82.22s (± 0.25%)}	_{81.53s (± 1.16%)}	_{-0.68s (- 0.83%)}	_79.62s	_82.03s	_{p=0.016 n=6}
_{Emit Time}	_{0.16s (± 2.52%)}	_{0.17s (± 3.32%)}	_~	_0.16s	_0.17s	_{p=0.282 n=6}
_{Total Time}	_{93.22s (± 0.20%)}	_{92.54s (± 1.00%)}	_{-0.67s (- 0.72%)}	_90.66s	_93.02s	_{p=0.013 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,290	_1,226,288	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,834	_260,837	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,342,594k (± 0.04%)}	_{2,342,915k (± 0.05%)}	_~	_2,341,631k	_2,344,408k	_{p=0.810 n=6}
_{Parse Time}	_{4.99s (± 1.57%)}	_{4.98s (± 1.10%)}	_~	_4.92s	_5.05s	_{p=0.872 n=6}
_{Bind Time}	_{1.91s (± 0.43%)}	_{1.89s (± 0.86%)}	_~	_1.87s	_1.91s	_{p=0.184 n=6}
_{Check Time}	_{33.87s (± 0.40%)}	_{33.89s (± 0.53%)}	_~	_33.68s	_34.11s	_{p=0.810 n=6}
_{Emit Time}	_{2.59s (± 2.79%)}	_{2.63s (± 3.90%)}	_~	_2.45s	_2.73s	_{p=0.423 n=6}
_{Total Time}	_{43.37s (± 0.58%)}	_{43.41s (± 0.52%)}	_~	_43.10s	_43.74s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,290	_1,226,288	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,834	_260,837	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,418,980k (± 0.02%)}	_{2,419,032k (± 0.04%)}	_~	_2,417,358k	_2,420,033k	_{p=0.689 n=6}
_{Parse Time}	_{5.17s (± 1.69%)}	_{5.17s (± 0.80%)}	_~	_5.13s	_5.25s	_{p=0.936 n=6}
_{Bind Time}	_{1.70s (± 0.44%)}	_{1.70s (± 0.49%)}	_~	_1.69s	_1.71s	_{p=0.432 n=6}
_{Check Time}	_{34.34s (± 0.22%)}	_{34.27s (± 0.36%)}	_~	_34.07s	_34.40s	_{p=0.521 n=6}
_{Emit Time}	_{2.62s (± 2.52%)}	_{2.60s (± 2.90%)}	_~	_2.52s	_2.69s	_{p=0.630 n=6}
_{Total Time}	_{43.84s (± 0.45%)}	_{43.77s (± 0.34%)}	_~	_43.63s	_44.03s	_{p=0.471 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_257,977	_257,975	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,898	_104,900	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{426,895k (± 0.01%)}	_{426,873k (± 0.01%)}	_~	_426,810k	_426,902k	_{p=0.298 n=6}
_{Parse Time}	_{3.32s (± 0.59%)}	_{3.33s (± 0.92%)}	_~	_3.30s	_3.38s	_{p=0.935 n=6}
_{Bind Time}	_{1.32s (± 1.14%)}	_{1.32s (± 1.14%)}	_~	_1.29s	_1.33s	_{p=1.000 n=6}
_{Check Time}	_{18.05s (± 0.36%)}	_{18.01s (± 0.46%)}	_~	_17.92s	_18.11s	_{p=0.422 n=6}
_{Emit Time}	_{1.33s (± 1.13%)}	_{1.33s (± 1.31%)}	_~	_1.32s	_1.36s	_{p=0.511 n=6}
_{Total Time}	_{24.02s (± 0.40%)}	_{23.99s (± 0.42%)}	_~	_23.89s	_24.14s	_{p=0.630 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,804k (± 0.03%)}	_{369,867k (± 0.03%)}	_~	_369,749k	_370,051k	_{p=0.378 n=6}
_{Parse Time}	_{3.54s (± 0.50%)}	_{3.52s (± 0.99%)}	_~	_3.47s	_3.55s	_{p=0.286 n=6}
_{Bind Time}	_{1.93s (± 1.02%)}	_{1.94s (± 0.62%)}	_~	_1.92s	_1.95s	_{p=0.415 n=6}
_{Check Time}	_{19.38s (± 0.33%)}	_{19.36s (± 0.16%)}	_~	_19.30s	_19.38s	_{p=0.292 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.84s (± 0.24%)}	_{24.81s (± 0.20%)}	_~	_24.73s	_24.86s	_{p=0.684 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,840,799	_2,840,799	_~	_~	_~	_{p=1.000 n=6}
_Types	_962,729	_962,729	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,014,042k (± 0.00%)}	_{3,014,027k (± 0.00%)}	_~	_3,013,963k	_3,014,079k	_{p=0.378 n=6}
_{Parse Time}	_{13.82s (± 0.27%)}	_{13.82s (± 0.27%)}	_~	_13.77s	_13.87s	_{p=1.000 n=6}
_{Bind Time}	_{4.33s (± 1.85%)}	_{4.20s (± 2.21%)}	_~	_4.15s	_4.39s	_{p=0.105 n=6}
_{Check Time}	_{73.27s (± 0.23%)}	_{73.41s (± 0.34%)}	_~	_73.10s	_73.83s	_{p=0.229 n=6}
_{Emit Time}	_{23.47s (± 0.51%)}	_{23.53s (± 0.58%)}	_~	_23.31s	_23.70s	_{p=0.630 n=6}
_{Total Time}	_{114.89s (± 0.18%)}	_{114.95s (± 0.19%)}	_~	_114.64s	_115.23s	_{p=0.630 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,048	_266,048	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,470	_108,470	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,858k (± 0.02%)}	_{410,899k (± 0.02%)}	_~	_410,861k	_411,028k	_{p=0.471 n=6}
_{Parse Time}	_{4.78s (± 0.98%)}	_{4.79s (± 0.74%)}	_~	_4.75s	_4.85s	_{p=1.000 n=6}
_{Bind Time}	_{2.07s (± 1.18%)}	_{2.06s (± 0.66%)}	_~	_2.04s	_2.08s	_{p=0.461 n=6}
_{Check Time}	_{21.04s (± 0.22%)}	_{21.06s (± 0.29%)}	_~	_20.98s	_21.16s	_{p=0.517 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.88s (± 0.26%)}	_{27.91s (± 0.22%)}	_~	_27.81s	_27.99s	_{p=0.574 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_535,743	_535,743	_~	_~	_~	_{p=1.000 n=6}
_Types	_182,738	_182,741	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{470,396k (± 0.01%)}	_{470,388k (± 0.00%)}	_~	_470,345k	_470,410k	_{p=0.810 n=6}
_{Parse Time}	_{3.95s (± 0.46%)}	_{3.96s (± 0.36%)}	_~	_3.94s	_3.98s	_{p=0.324 n=6}
_{Bind Time}	_{1.49s (± 0.95%)}	_{1.48s (± 0.79%)}	_~	_1.47s	_1.50s	_{p=0.325 n=6}
_{Check Time}	_{22.70s (± 0.30%)}	_{22.64s (± 0.27%)}	_~	_22.56s	_22.70s	_{p=0.092 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.14s (± 0.31%)}	_{28.08s (± 0.22%)}	_~	_28.00s	_28.15s	_{p=0.257 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

gabritto · 2024-05-29T19:53:21Z

@typescript-bot pack this

typescript-bot · 2024-05-29T19:53:24Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-05-29T19:58:19Z

Hey @gabritto, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161979/artifacts?artifactName=tgz&fileId=1BFA18BBC6DA0A2A9A0BB31A899B882DF274F7A83CD3BA53C4D866A4F3E3280A02&fileName=/typescript-5.5.0-insiders.20240529.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58702-7".;

typescript-bot · 2024-05-29T20:26:53Z

@gabritto Here are the results of running the top 400 repos comparing main and refs/pull/58702/merge:

Everything looks good!

Andarist · 2024-05-30T08:16:07Z

tests/baselines/reference/templateLiteralTypes5.types

I'd add an extra test case to the original test file here based on Anders' comment in the other PR:

declare function bar<T extends string>(x: `${T}`): T; function baz<U extends string>(x: `${U}`) { return bar(x); }

Andarist · 2024-05-30T08:17:20Z

tests/baselines/reference/templateLiteralTypes5.errors.txt

+!!! error TS2322:         Type '"a"' is not assignable to type '`${T2}`'.
+
+    function f3<T3 extends "a" | "b">(x: T3) {
+        const test1: `${T3}` = x    


it could be nice to add comments to both of those assignments to explain the error, like:

Suggested change

const test1: `${T3}` = x

const test1: `${T3}` = x; // error, T3 could be instantiated with a string enum

* upstream/main: (37 commits) Added NoTruncation flag to completions (microsoft#58719) Clone node to remove location even when it has been modified if needed (microsoft#58706) Properly account for `this` argument in intersection apparent type caching (microsoft#58677) Fix: Include Values of Script Extensions for Unicode Property Value Expressions in Regular Expressions (microsoft#58615) In `reScanSlashToken` use `charCodeChecked` not `codePointChecked` (microsoft#58727) Shorten error spans for errors reported on constructor declarations (microsoft#58061) Mark file as skips typechecking if it contains ts-nocheck (microsoft#58593) Fixed an issue with broken `await using` declarations in `for of` loops (microsoft#56466) Do not expand type references in keyof and index access (microsoft#58715) Improve the performance of isolatedDeclarations quickfix (microsoft#58722) Unwrap `NoInfer` types when narrowing (microsoft#58292) Recover from type reuse errors by falling back to inferred type printing (microsoft#58720) Fixing self import (microsoft#58718) Enable JS emit for noCheck and noCheck for transpileModule (microsoft#58364) Revert PR 55371 (microsoft#58702) Update dependencies (microsoft#58639) Fix baselines after PR 58621 (microsoft#58705) Do not infer `yield*` type from contextual `TReturn` (microsoft#58621) `await using` normative changes (microsoft#58624) Handling statements from a known source file (microsoft#58679) ...

revert changes in checker

f62cc7a

typescript-bot assigned gabritto May 29, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 29, 2024

gabritto marked this pull request as ready for review May 29, 2024 19:37

gabritto marked this pull request as draft May 29, 2024 19:42

add test

7dedaf2

gabritto requested a review from ahejlsberg May 29, 2024 20:20

Andarist reviewed May 30, 2024

View reviewed changes

ahejlsberg approved these changes May 30, 2024

View reviewed changes

gabritto marked this pull request as ready for review May 30, 2024 16:38

gabritto merged commit b7d8809 into main May 30, 2024
28 checks passed

gabritto deleted the gabritto/revert55371 branch May 30, 2024 16:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert PR 55371 #58702

Revert PR 55371 #58702

gabritto commented May 29, 2024

gabritto commented May 29, 2024

typescript-bot commented May 29, 2024 •

edited

Loading

typescript-bot commented May 29, 2024

typescript-bot commented May 29, 2024

typescript-bot commented May 29, 2024

tsc

gabritto commented May 29, 2024

typescript-bot commented May 29, 2024 •

edited

Loading

typescript-bot commented May 29, 2024 •

edited

Loading

typescript-bot commented May 29, 2024

Andarist May 30, 2024

Andarist May 30, 2024

	const test1: `${T3}` = x
	const test1: `${T3}` = x; // error, T3 could be instantiated with a string enum

Revert PR 55371 #58702

Revert PR 55371 #58702

Conversation

gabritto commented May 29, 2024

gabritto commented May 29, 2024

typescript-bot commented May 29, 2024 • edited Loading

typescript-bot commented May 29, 2024

typescript-bot commented May 29, 2024

typescript-bot commented May 29, 2024

tsc

gabritto commented May 29, 2024

typescript-bot commented May 29, 2024 • edited Loading

typescript-bot commented May 29, 2024 • edited Loading

typescript-bot commented May 29, 2024

Andarist May 30, 2024

Choose a reason for hiding this comment

Andarist May 30, 2024

Choose a reason for hiding this comment

typescript-bot commented May 29, 2024 •

edited

Loading

typescript-bot commented May 29, 2024 •

edited

Loading

typescript-bot commented May 29, 2024 •

edited

Loading