Skip typechecking file when generating declaraiton to get d.ts signature for incremental build #58592

sheetalkamat · 2024-05-20T19:02:35Z

Skips typechecking when emitting d.ts for determining if signature of the file has changed.
Sets cancellation token for emitting files to ensure that it is cancellable esp since files may not be type checked

tests/baselines/reference/tsc/cancellationToken/when-emitting-buildInfo.js

tests/baselines/reference/tsc/cancellationToken/when-using-state.js

tests/baselines/reference/tsbuildWatch/demo/updates-with-bad-reference.js

...sc/incremental/change-to-modifier-of-class-expression-field-with-declaration-emit-enabled.js

sheetalkamat · 2024-05-20T19:08:16Z

@weswigham i tried passing noCheck equivalent when running emit for dts emit and i see few tests failing. i have commented on each but if you can take a look and see what we can do for those scenarios that would be great. Thanks

…n resolve types etc without type checking

jakebailey · 2024-05-20T22:28:06Z

@typescript-bot perf test this faster

typescript-bot · 2024-05-20T22:28:09Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

src/testRunner/unittests/tsc/cancellationToken.ts

typescript-bot · 2024-05-20T23:04:12Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,192k (± 0.01%)}	_{192,800k (± 0.74%)}	_{+608k (+ 0.32%)}	_192,188k	_195,727k	_{p=0.030 n=6}
_{Parse Time}	_{1.28s (± 1.68%)}	_{1.27s (± 2.01%)}	_~	_1.25s	_1.32s	_{p=0.325 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.52s (± 0.29%)}	_{9.53s (± 0.39%)}	_~	_9.49s	_9.59s	_{p=0.806 n=6}
_{Emit Time}	_{2.66s (± 0.50%)}	_{2.63s (± 0.89%)}	_{-0.04s (- 1.38%)}	_2.58s	_2.64s	_{p=0.004 n=6}
_{Total Time}	_{14.19s (± 0.28%)}	_{14.14s (± 0.27%)}	_~	_14.10s	_14.21s	_{p=0.063 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,140	_407,140	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,159k (± 0.00%)}	_{1,222,121k (± 0.01%)}	_~	_1,222,000k	_1,222,166k	_{p=0.470 n=6}
_{Parse Time}	_{6.79s (± 0.58%)}	_{6.79s (± 0.87%)}	_~	_6.74s	_6.89s	_{p=1.000 n=6}
_{Bind Time}	_{1.87s (± 0.73%)}	_{1.87s (± 0.56%)}	_~	_1.85s	_1.88s	_{p=0.249 n=6}
_{Check Time}	_{31.27s (± 0.39%)}	_{31.30s (± 0.34%)}	_~	_31.19s	_31.46s	_{p=1.000 n=6}
_{Emit Time}	_{14.69s (± 0.71%)}	_{14.78s (± 0.51%)}	_~	_14.69s	_14.89s	_{p=0.127 n=6}
_{Total Time}	_{54.63s (± 0.29%)}	_{54.74s (± 0.11%)}	_~	_54.67s	_54.83s	_{p=0.296 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,979,156	_1,979,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_882,049	_882,049	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,885,000k (± 0.00%)}	_{1,885,028k (± 0.00%)}	_~	_1,884,960k	_1,885,081k	_{p=0.336 n=6}
_{Parse Time}	_{6.78s (± 0.55%)}	_{6.77s (± 0.43%)}	_~	_6.74s	_6.80s	_{p=0.745 n=6}
_{Bind Time}	_{2.29s (± 0.71%)}	_{2.28s (± 0.45%)}	_~	_2.27s	_2.30s	_{p=0.249 n=6}
_{Check Time}	_{60.43s (± 0.27%)}	_{60.30s (± 0.21%)}	_~	_60.10s	_60.45s	_{p=0.261 n=6}
_{Emit Time}	_{0.14s (± 2.88%)}	_{0.14s (± 2.88%)}	_~	_0.14s	_0.15s	_{p=1.000 n=6}
_{Total Time}	_{69.64s (± 0.22%)}	_{69.50s (± 0.14%)}	_~	_69.34s	_69.60s	_{p=0.127 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,222,772	_1,222,880	_{+108 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,022	_260,033	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,338,865k (± 0.04%)}	_{2,338,979k (± 0.03%)}	_~	_2,338,373k	_2,340,173k	_{p=0.471 n=6}
_{Parse Time}	_{4.98s (± 1.38%)}	_{5.03s (± 0.74%)}	_~	_4.99s	_5.08s	_{p=0.199 n=6}
_{Bind Time}	_{1.89s (± 0.86%)}	_{1.89s (± 0.75%)}	_~	_1.87s	_1.91s	_{p=0.744 n=6}
_{Check Time}	_{33.83s (± 0.41%)}	_{33.80s (± 0.43%)}	_~	_33.54s	_33.93s	_{p=1.000 n=6}
_{Emit Time}	_{2.68s (± 2.44%)}	_{2.68s (± 1.86%)}	_~	_2.60s	_2.75s	_{p=0.936 n=6}
_{Total Time}	_{43.40s (± 0.37%)}	_{43.42s (± 0.23%)}	_~	_43.31s	_43.54s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,222,772	_1,222,880	_{+108 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,022	_260,033	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,557,479k (±13.60%)}	_{2,415,525k (± 0.05%)}	_~	_2,413,955k	_2,417,253k	_{p=0.936 n=6}
_{Parse Time}	_{7.78s (± 1.48%)}	_{7.76s (± 1.03%)}	_~	_7.60s	_7.82s	_{p=0.810 n=6}
_{Bind Time}	_{2.49s (± 0.97%)}	_{2.51s (± 0.89%)}	_~	_2.49s	_2.54s	_{p=0.147 n=6}
_{Check Time}	_{49.88s (± 0.69%)}	_{49.79s (± 0.39%)}	_~	_49.51s	_49.98s	_{p=1.000 n=6}
_{Emit Time}	_{3.92s (± 2.95%)}	_{3.91s (± 3.15%)}	_~	_3.80s	_4.10s	_{p=0.810 n=6}
_{Total Time}	_{64.07s (± 0.65%)}	_{63.99s (± 0.17%)}	_~	_63.83s	_64.14s	_{p=0.575 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_257,595	_257,626	_{+31 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,862	_104,872	_{+10 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{426,567k (± 0.01%)}	_{426,592k (± 0.01%)}	_~	_426,480k	_426,648k	_{p=0.471 n=6}
_{Parse Time}	_{3.37s (± 0.62%)}	_{3.37s (± 0.35%)}	_~	_3.35s	_3.38s	_{p=0.744 n=6}
_{Bind Time}	_{1.32s (± 0.91%)}	_{1.33s (± 0.61%)}	_~	_1.31s	_1.33s	_{p=0.599 n=6}
_{Check Time}	_{17.93s (± 0.37%)}	_{17.94s (± 0.44%)}	_~	_17.85s	_18.04s	_{p=0.872 n=6}
_{Emit Time}	_{1.38s (± 1.83%)}	_{1.36s (± 0.90%)}	_~	_1.35s	_1.38s	_{p=0.254 n=6}
_{Total Time}	_{24.00s (± 0.28%)}	_{24.00s (± 0.36%)}	_~	_23.88s	_24.11s	_{p=0.936 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,899k (± 0.02%)}	_{369,889k (± 0.03%)}	_~	_369,709k	_370,021k	_{p=0.873 n=6}
_{Parse Time}	_{2.85s (± 1.21%)}	_{2.84s (± 0.96%)}	_~	_2.81s	_2.88s	_{p=0.327 n=6}
_{Bind Time}	_{1.58s (± 0.93%)}	_{1.58s (± 0.53%)}	_~	_1.58s	_1.60s	_{p=0.358 n=6}
_{Check Time}	_{15.65s (± 0.31%)}	_{15.70s (± 0.32%)}	_~	_15.61s	_15.76s	_{p=0.090 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.09s (± 0.28%)}	_{20.12s (± 0.27%)}	_~	_20.05s	_20.20s	_{p=0.415 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,825,740	_2,825,740	_~	_~	_~	_{p=1.000 n=6}
_Types	_958,540	_958,540	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,000,009k (± 0.00%)}	_{3,000,009k (± 0.00%)}	_~	_2,999,958k	_3,000,066k	_{p=0.936 n=6}
_{Parse Time}	_{13.81s (± 0.17%)}	_{13.81s (± 0.40%)}	_~	_13.73s	_13.89s	_{p=0.936 n=6}
_{Bind Time}	_{4.21s (± 2.64%)}	_{4.15s (± 0.35%)}	_~	_4.13s	_4.17s	_{p=0.934 n=6}
_{Check Time}	_{73.60s (± 0.52%)}	_{74.16s (± 1.86%)}	_~	_73.32s	_76.94s	_{p=0.575 n=6}
_{Emit Time}	_{23.55s (± 1.06%)}	_{22.71s (± 6.78%)}	_~	_19.64s	_23.66s	_{p=0.230 n=6}
_{Total Time}	_{115.17s (± 0.28%)}	_{114.82s (± 0.27%)}	_~	_114.48s	_115.37s	_{p=0.128 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,866	_265,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,401	_108,401	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,539k (± 0.01%)}	_{410,567k (± 0.01%)}	_~	_410,511k	_410,631k	_{p=0.173 n=6}
_{Parse Time}	_{4.75s (± 0.80%)}	_{4.76s (± 0.79%)}	_~	_4.71s	_4.81s	_{p=0.466 n=6}
_{Bind Time}	_{2.06s (± 1.18%)}	_{2.05s (± 0.66%)}	_~	_2.04s	_2.07s	_{p=0.934 n=6}
_{Check Time}	_{20.96s (± 0.43%)}	_{20.95s (± 0.29%)}	_~	_20.89s	_21.03s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.75s (± 0.27%)}	_{27.78s (± 0.24%)}	_~	_27.69s	_27.85s	_{p=0.748 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,654	_524,654	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,920	_178,920	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,708k (± 0.02%)}	_{462,732k (± 0.02%)}	_~	_462,599k	_462,788k	_{p=0.936 n=6}
_{Parse Time}	_{3.90s (± 0.39%)}	_{3.90s (± 0.39%)}	_~	_3.88s	_3.92s	_{p=1.000 n=6}
_{Bind Time}	_{1.43s (± 0.58%)}	_{1.45s (± 0.84%)}	_~	_1.43s	_1.46s	_{p=0.093 n=6}
_{Check Time}	_{22.54s (± 0.83%)}	_{22.49s (± 0.64%)}	_~	_22.33s	_22.68s	_{p=0.575 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.86s (± 0.68%)}	_{27.83s (± 0.48%)}	_~	_27.72s	_28.04s	_{p=0.574 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-05-21T00:29:02Z

Is this the winning PR or is #58593 still something to consider? Just checking before I review...

weswigham

Is this the winning PR or is #58593 still something to consider? Just checking before I review...

They don't appear mutually exclusive to my eye. This one skips the diagnostic pass when calculating signatures. The other skips it when a //@ts-nocheck comment is in a file.

src/compiler/checker.ts

src/testRunner/unittests/tsc/cancellationToken.ts

…ing emitResolver

src/compiler/checker.ts

weswigham

Oh, one caveat though - #58364 isn't in yet, so JS emit is unsafe when you skip diagnostics like this. Is an emit resolver with forceDtsEmit set guaranteed to be only emitting .d.ts files?

jakebailey · 2024-05-21T18:21:08Z

I don't think that it is guaranteed; I almost made the playground always set forceDtsEmit because it always needs to show it (playground used to crash on dts errors), though I think I actually made it conditional in the current version.

sheetalkamat · 2024-05-21T19:20:35Z

Yes it is guaranteed to be dts only emit as "forceDtsEmit" is internal on program.emit and used only by builder

jakebailey · 2024-05-21T19:22:03Z

Isn't it public via getEmitOutput #34495? Or does that not matter?

sheetalkamat · 2024-05-21T19:28:24Z

LS.. compile on save.. forgot about that. :( i will upate the condition for now to check if its emitOnlyDts and forceDtsEmit to be true which we can later update in #58364 to remove emitOnlyDts part.

…it to be done without type checking

sheetalkamat added 2 commits May 20, 2024 11:44

Experiment noChecking when forcing dts emit

ac190d1

Tests failing

bf87f26

typescript-bot assigned sheetalkamat May 20, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 20, 2024

sheetalkamat commented May 20, 2024

View reviewed changes

tests/baselines/reference/tsc/cancellationToken/when-emitting-buildInfo.js Outdated Show resolved Hide resolved

sheetalkamat commented May 20, 2024

View reviewed changes

tests/baselines/reference/tsc/cancellationToken/when-using-state.js Outdated Show resolved Hide resolved

sheetalkamat commented May 20, 2024

View reviewed changes

tests/baselines/reference/tsbuildWatch/demo/updates-with-bad-reference.js Outdated Show resolved Hide resolved

sheetalkamat commented May 20, 2024

View reviewed changes

...sc/incremental/change-to-modifier-of-class-expression-field-with-declaration-emit-enabled.js Outdated Show resolved Hide resolved

sheetalkamat mentioned this pull request May 20, 2024

Mark file as skips typechecking if it contains ts-nocheck #58593

Merged

sheetalkamat added 2 commits May 20, 2024 14:05

Collect aliases

23f7204

Emit with cancellation token enabled esp now that declaration emit ca…

d9fce93

…n resolve types etc without type checking

sheetalkamat changed the title ~~[Experiment] Skip typechecking file when generating declaraiton to get d.ts signature for incremental build~~ Skip typechecking file when generating declaraiton to get d.ts signature for incremental build May 20, 2024

sheetalkamat requested review from weswigham, andrewbranch and jakebailey May 20, 2024 22:22

sheetalkamat marked this pull request as ready for review May 20, 2024 22:22

weswigham reviewed May 20, 2024

View reviewed changes

src/testRunner/unittests/tsc/cancellationToken.ts Outdated Show resolved Hide resolved

Remove debugging leftover

5cc1ea4

sheetalkamat force-pushed the noCheckWithDtsEmit branch from 516c734 to 5cc1ea4 Compare May 20, 2024 23:03

weswigham reviewed May 21, 2024

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

src/testRunner/unittests/tsc/cancellationToken.ts Show resolved Hide resolved

Check directly for forceDtsEmit before getting diagnostics and return…

0a23381

…ing emitResolver

sheetalkamat requested a review from weswigham May 21, 2024 16:42

weswigham approved these changes May 21, 2024

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

weswigham reviewed May 21, 2024

View reviewed changes

Handle emitOnlyDts for now since #58364 is yet to be merged for js em…

c4af1f5

…it to be done without type checking

sheetalkamat requested a review from weswigham May 21, 2024 19:43

weswigham approved these changes May 21, 2024

View reviewed changes

sheetalkamat merged commit cd40d26 into main May 21, 2024
28 checks passed

sheetalkamat deleted the noCheckWithDtsEmit branch May 21, 2024 21:09

sheetalkamat mentioned this pull request May 21, 2024

Incremental compile can spend time type checking files with @ts-nocheck #56956

Closed

sheetalkamat linked an issue May 21, 2024 that may be closed by this pull request

Incremental compile can spend time type checking files with @ts-nocheck #56956

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip typechecking file when generating declaraiton to get d.ts signature for incremental build #58592

Skip typechecking file when generating declaraiton to get d.ts signature for incremental build #58592

sheetalkamat commented May 20, 2024 •

edited

Loading

sheetalkamat commented May 20, 2024

jakebailey commented May 20, 2024

typescript-bot commented May 20, 2024 •

edited

Loading

typescript-bot commented May 20, 2024

tsc

jakebailey commented May 21, 2024

weswigham left a comment

weswigham left a comment

jakebailey commented May 21, 2024

sheetalkamat commented May 21, 2024

jakebailey commented May 21, 2024

sheetalkamat commented May 21, 2024

Skip typechecking file when generating declaraiton to get d.ts signature for incremental build #58592

Skip typechecking file when generating declaraiton to get d.ts signature for incremental build #58592

Conversation

sheetalkamat commented May 20, 2024 • edited Loading

sheetalkamat commented May 20, 2024

jakebailey commented May 20, 2024

typescript-bot commented May 20, 2024 • edited Loading

typescript-bot commented May 20, 2024

tsc

jakebailey commented May 21, 2024

weswigham left a comment

Choose a reason for hiding this comment

weswigham left a comment

Choose a reason for hiding this comment

jakebailey commented May 21, 2024

sheetalkamat commented May 21, 2024

jakebailey commented May 21, 2024

sheetalkamat commented May 21, 2024

sheetalkamat commented May 20, 2024 •

edited

Loading

typescript-bot commented May 20, 2024 •

edited

Loading