fix55816: exclude files with re-exports if excluded by preferences.autoImportFileExcludePatterns

[iisaduan]

Fixes #55816

This failure happened when a file foo.ts that re-exports some variable T is ignored by "typescript.preferences.autoImportFileExcludePatterns". foo.ts was properly ignored by exportMap, but the autoImports still attempted to generate the import with foo.ts instead of the file that originally exported T, which lead to a failure.

This PR allows the moduleSymbol found by autoImports to not match the moduleSymbol found by exportInfoMap if the moduleSymbol found by autoimports is excluded. Furthermore, if the import info still cannot be resolved, the quickfix will still be available and we will generate the implementation code without the import statement.

[fatcerberus]

Fixes #55816

Is that the right issue? It seems unrelated.

[iisaduan]

It is the correct issue, see the call stack here. The quick fix is not offered because getting autoimports fails when the file is excluded in preferences

[andrewbranch]

Plot twist: all existing tests pass if you delete this entire info.some(...) part of the condition. That might be all that’s needed to fix the bug?

[iisaduan]

I tried that and wasn't sure if that was the best fix, since I tracked it back to here, where it looked like it was intentionally added. :D if your opinion is that the check was unnecessary, I'll change it back to just deleting this extra check

[iisaduan]

Actually, I remember something did break when I tried that-- tests/cases/fourslash/server/autoImportReExportFromAmbientModule.ts breaks with the info.some call removed. Since exporting ambient modules doesn't use filenames, I figured it would be alright to skip the check for ignored files

[andrewbranch]

Suggested change

	&& info.some(i => moduleSymbolExcluded || i.moduleSymbol === moduleSymbol || i.symbol.parent === moduleSymbol)
	&& (moduleSymbolExcluded || info.some(i => i.moduleSymbol === moduleSymbol || i.symbol.parent === moduleSymbol))

[andrewbranch]

Suggested change

	&& info.some(i => moduleSymbolExcluded || i.moduleSymbol === moduleSymbol || i.symbol.parent === moduleSymbol)
	&& (moduleSymbolExcluded || info.some(i => i.moduleSymbol === moduleSymbol || i.symbol.parent === moduleSymbol))

[iisaduan]

@typescript-bot pack this

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
pack this	✅ Started

[andrewbranch]

Huh, this one with the broken import ended up working? What’s different from when we debugged it yesterday and this was crashing? Is there a test case that exercises if (!exportInfo) return;?

[iisaduan]

Yes, the broken import that we fixed was in thing,ts, and the file that the codefix was triggered in is in a different part of the folder tree than thing

[iisaduan]

I was trying to make cases with other file structures, since I was trying to test if the codefix would still crash in situations where the import map resolved to a different preferred file to generate the import from

[iisaduan]

I added a debug statement to only exit quietly if preferences.autoImportFileExcludePatterns is provided, like @andrewbranch mentioned. It seems that otherwise, if the import was unresolved, autoimports goes through other functions to try to generate imports.