Do not lowercase typeReference directive name #58525

sheetalkamat · 2024-05-13T21:07:21Z

As part of #9824 all type reference directives are lower cased so type="somePackage" results in looking for type reference of somepackage instead.

We also did not lowercase file names found as part of auto type references. So there was always some descripency with how we handled typeRef. Now with this change, it's as written.

I reverted that part and only kept the jsTypings to do the lowercasing to find the @types packages to install.
This fixes issues with forceConsistentCasingInFileNames esp when using relative paths in types reference.

#26948 becomes absolute with this
Fixes #45096

sheetalkamat · 2024-05-13T21:07:33Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot test tsserver top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2024-05-13T21:07:36Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top100`	✅ Started	✅ Results
`test tsserver top100`	✅ Started
`user test this`	✅ Started	✅ Results
`user test tsserver`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-05-13T21:12:08Z

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161724/artifacts?artifactName=tgz&fileId=B651C045846EEB2FC90BE3CE603705831C8A890856CD515773A0DF0BF360115702&fileName=/typescript-5.5.0-insiders.20240513.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58525-2".;

typescript-bot · 2024-05-13T21:30:31Z

Hey @sheetalkamat, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-05-13T21:31:11Z

@sheetalkamat Here are the results of running the user tests comparing main and refs/pull/58525/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"

Otherwise...

Everything looks good!

typescript-bot · 2024-05-13T21:36:17Z

@sheetalkamat Here are the results of running the user tests comparing main and refs/pull/58525/merge:

Everything looks good!

typescript-bot · 2024-05-13T21:43:28Z

@sheetalkamat
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,857k (± 0.77%)}	_{194,049k (± 1.02%)}	_~	_192,199k	_195,916k	_{p=0.689 n=6}
_{Parse Time}	_{1.55s (± 0.63%)}	_{1.54s (± 1.77%)}	_~	_1.51s	_1.58s	_{p=0.935 n=6}
_{Bind Time}	_{0.87s (± 1.19%)}	_{0.87s (± 0.97%)}	_~	_0.86s	_0.88s	_{p=0.923 n=6}
_{Check Time}	_{11.30s (± 0.52%)}	_{11.30s (± 0.32%)}	_~	_11.27s	_11.37s	_{p=0.688 n=6}
_{Emit Time}	_{3.14s (± 0.81%)}	_{3.14s (± 0.84%)}	_~	_3.10s	_3.18s	_{p=1.000 n=6}
_{Total Time}	_{16.86s (± 0.52%)}	_{16.85s (± 0.19%)}	_~	_16.82s	_16.90s	_{p=0.466 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,140	_407,140	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,071k (± 0.00%)}	_{1,222,049k (± 0.00%)}	_~	_1,221,988k	_1,222,103k	_{p=0.173 n=6}
_{Parse Time}	_{8.10s (± 0.48%)}	_{8.09s (± 0.48%)}	_~	_8.05s	_8.15s	_{p=0.935 n=6}
_{Bind Time}	_{2.25s (± 0.54%)}	_{2.24s (± 0.66%)}	_~	_2.22s	_2.25s	_{p=0.410 n=6}
_{Check Time}	_{36.53s (± 0.28%)}	_{36.37s (± 0.52%)}	_~	_36.17s	_36.65s	_{p=0.128 n=6}
_{Emit Time}	_{17.45s (± 0.42%)}	_{17.44s (± 0.35%)}	_~	_17.33s	_17.50s	_{p=0.936 n=6}
_{Total Time}	_{64.33s (± 0.18%)}	_{64.14s (± 0.24%)}	_~	_63.93s	_64.39s	_{p=0.093 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,961,349	_1,961,349	_~	_~	_~	_{p=1.000 n=6}
_Types	_696,910	_696,910	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,778,045k (± 0.00%)}	_{1,778,084k (± 0.00%)}	_~	_1,778,043k	_1,778,123k	_{p=0.148 n=6}
_{Parse Time}	_{9.88s (± 0.58%)}	_{9.87s (± 0.20%)}	_~	_9.84s	_9.89s	_{p=0.418 n=6}
_{Bind Time}	_{3.38s (± 1.24%)}	_{3.37s (± 0.56%)}	_~	_3.33s	_3.38s	_{p=0.572 n=6}
_{Check Time}	_{82.95s (± 0.44%)}	_{82.66s (± 0.51%)}	_~	_82.02s	_83.18s	_{p=0.423 n=6}
_{Emit Time}	_{0.20s (± 2.02%)}	_{0.20s (± 2.02%)}	_~	_0.20s	_0.21s	_{p=1.000 n=6}
_{Total Time}	_{96.42s (± 0.36%)}	_{96.10s (± 0.47%)}	_~	_95.39s	_96.63s	_{p=0.298 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,221,120	_1,221,139	_{+19 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,503	_259,515	_{+12 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,387,138k (± 3.24%)}	_{2,362,143k (± 2.58%)}	_~	_2,337,082k	_2,486,910k	_{p=0.810 n=6}
_{Parse Time}	_{5.97s (± 0.85%)}	_{6.06s (± 1.16%)}	_{+0.09s (+ 1.48%)}	_5.97s	_6.17s	_{p=0.030 n=6}
_{Bind Time}	_{2.25s (± 1.12%)}	_{2.24s (± 0.46%)}	_~	_2.23s	_2.26s	_{p=0.575 n=6}
_{Check Time}	_{39.81s (± 0.46%)}	_{39.69s (± 0.26%)}	_~	_39.56s	_39.83s	_{p=0.173 n=6}
_{Emit Time}	_{3.16s (± 2.18%)}	_{3.22s (± 1.23%)}	_~	_3.16s	_3.28s	_{p=0.149 n=6}
_{Total Time}	_{51.20s (± 0.42%)}	_{51.21s (± 0.19%)}	_~	_51.09s	_51.36s	_{p=0.809 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,221,120	_1,221,139	_{+19 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,503	_259,515	_{+12 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,412,241k (± 0.02%)}	_{2,413,032k (± 0.04%)}	_~	_2,411,683k	_2,413,903k	_{p=0.173 n=6}
_{Parse Time}	_{6.32s (± 1.08%)}	_{6.25s (± 1.22%)}	_~	_6.13s	_6.36s	_{p=0.230 n=6}
_{Bind Time}	_{2.04s (± 0.67%)}	_{2.05s (± 0.96%)}	_~	_2.02s	_2.08s	_{p=0.125 n=6}
_{Check Time}	_{40.20s (± 0.35%)}	_{40.23s (± 0.24%)}	_~	_40.07s	_40.34s	_{p=0.575 n=6}
_{Emit Time}	_{3.21s (± 2.98%)}	_{3.15s (± 1.71%)}	_~	_3.09s	_3.22s	_{p=0.298 n=6}
_{Total Time}	_{51.76s (± 0.47%)}	_{51.69s (± 0.07%)}	_~	_51.63s	_51.73s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,716	_256,716	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,580	_104,580	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{425,916k (± 0.01%)}	_{425,888k (± 0.02%)}	_~	_425,764k	_425,969k	_{p=0.873 n=6}
_{Parse Time}	_{4.17s (± 0.67%)}	_{4.17s (± 0.50%)}	_~	_4.15s	_4.20s	_{p=0.628 n=6}
_{Bind Time}	_{1.61s (± 1.07%)}	_{1.61s (± 0.52%)}	_~	_1.61s	_1.63s	_{p=0.742 n=6}
_{Check Time}	_{22.18s (± 0.20%)}	_{22.17s (± 0.28%)}	_~	_22.11s	_22.28s	_{p=0.520 n=6}
_{Emit Time}	_{1.71s (± 1.15%)}	_{1.71s (± 1.59%)}	_~	_1.67s	_1.75s	_{p=0.625 n=6}
_{Total Time}	_{29.67s (± 0.19%)}	_{29.66s (± 0.25%)}	_~	_29.61s	_29.81s	_{p=0.747 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,867k (± 0.03%)}	_{369,801k (± 0.02%)}	_~	_369,718k	_369,865k	_{p=0.688 n=6}
_{Parse Time}	_{3.52s (± 0.86%)}	_{3.49s (± 0.86%)}	_~	_3.46s	_3.53s	_{p=0.260 n=6}
_{Bind Time}	_{1.93s (± 1.08%)}	_{1.94s (± 0.77%)}	_~	_1.92s	_1.96s	_{p=0.139 n=6}
_{Check Time}	_{19.29s (± 0.17%)}	_{19.35s (± 0.27%)}	_~	_19.29s	_19.43s	_{p=0.064 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.73s (± 0.23%)}	_{24.78s (± 0.30%)}	_~	_24.69s	_24.92s	_{p=0.167 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,822,274	_2,822,274	_~	_~	_~	_{p=1.000 n=6}
_Types	_957,520	_957,520	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,994,876k (± 0.00%)}	_{2,994,871k (± 0.00%)}	_~	_2,994,807k	_2,994,968k	_{p=0.471 n=6}
_{Parse Time}	_{13.84s (± 0.28%)}	_{13.83s (± 0.14%)}	_~	_13.81s	_13.86s	_{p=0.416 n=6}
_{Bind Time}	_{4.15s (± 0.26%)}	_{4.14s (± 0.22%)}	_~	_4.13s	_4.15s	_{p=0.149 n=6}
_{Check Time}	_{73.30s (± 0.24%)}	_{73.37s (± 0.42%)}	_~	_73.11s	_73.96s	_{p=1.000 n=6}
_{Emit Time}	_{23.54s (± 0.69%)}	_{23.56s (± 0.49%)}	_~	_23.45s	_23.73s	_{p=0.936 n=6}
_{Total Time}	_{114.83s (± 0.29%)}	_{114.90s (± 0.25%)}	_~	_114.57s	_115.40s	_{p=0.630 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,866	_265,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,401	_108,401	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,574k (± 0.01%)}	_{410,637k (± 0.02%)}	_~	_410,512k	_410,760k	_{p=0.298 n=6}
_{Parse Time}	_{3.21s (± 0.41%)}	_{3.20s (± 0.46%)}	_~	_3.18s	_3.22s	_{p=0.617 n=6}
_{Bind Time}	_{1.41s (± 0.97%)}	_{1.39s (± 0.75%)}	_~	_1.38s	_1.41s	_{p=0.161 n=6}
_{Check Time}	_{14.37s (± 0.43%)}	_{14.44s (± 0.33%)}	_~	_14.38s	_14.51s	_{p=0.064 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.98s (± 0.29%)}	_{19.03s (± 0.22%)}	_~	_18.99s	_19.09s	_{p=0.107 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,639	_524,639	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,906	_178,906	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,741k (± 0.01%)}	_{462,651k (± 0.01%)}	_{-89k (- 0.02%)}	_462,570k	_462,716k	_{p=0.020 n=6}
_{Parse Time}	_{2.62s (± 0.57%)}	_{2.61s (± 0.75%)}	_~	_2.58s	_2.64s	_{p=0.315 n=6}
_{Bind Time}	_{1.00s (± 0.84%)}	_{0.98s (± 1.06%)}	_{-0.02s (- 1.84%)}	_0.96s	_0.99s	_{p=0.016 n=6}
_{Check Time}	_{15.32s (± 0.36%)}	_{15.35s (± 0.67%)}	_~	_15.22s	_15.52s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.93s (± 0.33%)}	_{18.93s (± 0.43%)}	_~	_18.82s	_19.06s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,761ms (± 0.36%)}	_{2,876ms (± 9.58%)}	_~	_2,743ms	_3,438ms	_{p=0.374 n=6}
_{Req 2 - geterr}	_{6,159ms (± 0.62%)}	_{6,587ms (± 9.87%)}	_~	_6,103ms	_7,431ms	_{p=0.378 n=6}
_{Req 3 - references}	_{348ms (± 1.64%)}	_{349ms (± 1.61%)}	_~	_343ms	_355ms	_{p=0.746 n=6}
_{Req 4 - navto}	_{279ms (± 0.44%)}	_{279ms (± 0.54%)}	_~	_277ms	_281ms	_{p=0.931 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{96ms (± 9.29%)}	_{100ms (±11.90%)}	_~	_92ms	_115ms	_{p=0.774 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,428ms (± 0.45%)}	_{2,442ms (± 0.60%)}	_{+14ms (+ 0.58%)}	_2,432ms	_2,471ms	_{p=0.045 n=6}
_{Req 2 - geterr}	_{3,868ms (± 0.25%)}	_{3,865ms (± 0.12%)}	_~	_3,859ms	_3,871ms	_{p=0.377 n=6}
_{Req 3 - references}	_{297ms (± 0.55%)}	_{297ms (± 0.41%)}	_~	_296ms	_299ms	_{p=0.357 n=6}
_{Req 4 - navto}	_{228ms (± 0.24%)}	_{228ms (± 1.06%)}	_~	_226ms	_233ms	_{p=0.663 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{75ms (± 5.99%)}	_{79ms (± 8.61%)}	_~	_68ms	_84ms	_{p=0.389 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,121ms (± 0.28%)}	_{5,116ms (± 0.22%)}	_~	_5,100ms	_5,130ms	_{p=0.471 n=6}
_{Req 2 - geterr}	_{1,120ms (± 1.61%)}	_{1,130ms (± 1.87%)}	_~	_1,096ms	_1,147ms	_{p=0.378 n=6}
_{Req 3 - references}	_{88ms (± 3.29%)}	_{90ms (± 3.46%)}	_~	_84ms	_93ms	_{p=0.170 n=6}
_{Req 4 - navto}	_{449ms (± 3.62%)}	_{452ms (± 0.46%)}	_~	_450ms	_456ms	_{p=0.809 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{861ms (± 2.37%)}	_{875ms (± 1.31%)}	_~	_860ms	_891ms	_{p=0.199 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{156.72ms (± 0.16%)}	_{156.55ms (± 0.15%)}	_{-0.16ms (- 0.11%)}	_155.65ms	_158.54ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{240.69ms (± 0.14%)}	_{240.66ms (± 0.14%)}	_~	_238.96ms	_245.79ms	_{p=0.617 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{237.05ms (± 0.18%)}	_{237.01ms (± 0.17%)}	_~	_235.42ms	_244.62ms	_{p=0.336 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{236.14ms (± 0.16%)}	_{236.01ms (± 0.16%)}	_{-0.12ms (- 0.05%)}	_234.57ms	_240.88ms	_{p=0.002 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-05-13T23:09:17Z

@sheetalkamat Here are the results of running the top 400 repos comparing main and refs/pull/58525/merge:

Everything looks good!

sheetalkamat · 2024-05-13T23:10:13Z

...ce/tsserver/typeReferenceDirectives/when-typeReferenceDirective-contains-UpperCasePackage.js

@@ -117,7 +166,6 @@ Info seq  [hh:mm:ss:mss] 	Files (4)
 	  Matched by default include pattern '**/*'
 	../lib/@types/UpperCasePackage/index.d.ts
 	  Entry point for implicit type library 'UpperCasePackage'
-	  Type library referenced via 'UpperCasePackage' from file '../lib/@app/lib/index.d.ts'


This stops showing as this because of how this is processed. When the UpperCasePackage typings are already found and are primary then they are not processed again and hence the file reason for this is never added. Thats a separate issue and am looking into updating that code as well but its not related to this change.

it just stopped showing because before this the package name by auto type ref was "UpperCasePackage" while by type Ref was "uppercasepackage" which made two distinct entries and hence processed again.

andrewbranch

This seems correct, but it also seems like a lot of people in the linked issue are misusing type reference directives. They’re not really supposed to resolve to files, right? They should be package directories in typeRoots?

sheetalkamat · 2024-05-13T23:28:42Z

Yes they are but given that we dont disallow relative names in the type it just seems like something we shouldnt do. I mean we shouldnt be in buisness of "lowercasing". Please write what you mean. So i feel like this is better change.

We started doing this because of "Jquery.min" etc files and some other auto type Aquisition issues. But if you write "types" in your file, write it with correct casing is logical i think.

sheetalkamat added 2 commits May 13, 2024 13:53

Tests

b407c7e

Dont lower case file name for type ref

8d92aef

typescript-bot assigned sheetalkamat May 13, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 13, 2024

Update conformance test

50d79ac

sheetalkamat mentioned this pull request May 13, 2024

Fix incorrect usage of getResolvedTypeReferenceDirectives and some refactoring #58527

Merged

sheetalkamat changed the title ~~[wip] Dont lower case type ref~~ Do not lowercase typeReference directive name May 13, 2024

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 13, 2024

sheetalkamat requested review from andrewbranch, jakebailey and RyanCavanaugh May 13, 2024 22:31

Merge branch 'main' into dontLowerCaseTypeRef

d851dbd

sheetalkamat marked this pull request as ready for review May 13, 2024 23:07

sheetalkamat commented May 13, 2024

View reviewed changes

andrewbranch approved these changes May 13, 2024

View reviewed changes

sheetalkamat merged commit e51cbc8 into main May 13, 2024
28 checks passed

sheetalkamat deleted the dontLowerCaseTypeRef branch May 13, 2024 23:35

xavdid-stripe mentioned this pull request May 14, 2024

stripe-node bumps into TypeScript issue 45096 for triple slash directives when forceConsistentCasingInFileNames stripe/stripe-node#2076

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not lowercase typeReference directive name #58525

Do not lowercase typeReference directive name #58525

sheetalkamat commented May 13, 2024 •

edited

Loading

sheetalkamat commented May 13, 2024

typescript-bot commented May 13, 2024 •

edited

Loading

typescript-bot commented May 13, 2024 •

edited

Loading

typescript-bot commented May 13, 2024

typescript-bot commented May 13, 2024

typescript-bot commented May 13, 2024

typescript-bot commented May 13, 2024

tsc

tsserver

startup

typescript-bot commented May 13, 2024

sheetalkamat May 13, 2024

andrewbranch left a comment

sheetalkamat commented May 13, 2024

Do not lowercase typeReference directive name #58525

Do not lowercase typeReference directive name #58525

Conversation

sheetalkamat commented May 13, 2024 • edited Loading

sheetalkamat commented May 13, 2024

typescript-bot commented May 13, 2024 • edited Loading

typescript-bot commented May 13, 2024 • edited Loading

typescript-bot commented May 13, 2024

typescript-bot commented May 13, 2024

typescript-bot commented May 13, 2024

typescript-bot commented May 13, 2024

tsc

tsserver

startup

typescript-bot commented May 13, 2024

sheetalkamat May 13, 2024

Choose a reason for hiding this comment

andrewbranch left a comment

Choose a reason for hiding this comment

sheetalkamat commented May 13, 2024

sheetalkamat commented May 13, 2024 •

edited

Loading

typescript-bot commented May 13, 2024 •

edited

Loading

typescript-bot commented May 13, 2024 •

edited

Loading