Always send configFileDiagEvent and instead set triggerFile for more consistency #58462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
changed the title
sheetalkamat
commented
May 7, 2024
| const project = this.createAndLoadConfiguredProject(configFileName, reason); | ||
| project.skipConfigDiagEvent = true; | ||
| project.updateGraph(); | ||
| private createLoadAndUpdateConfiguredProject(configFileName: NormalizedPath, reason: string, triggerFile: NormalizedPath | undefined) { |
There was a problem hiding this comment.
Removed all the createConfiguredProjectAnd** methods except this one as now createConfiguredProject takes reason and sets the pending level to Full to correctly represent the state.
sheetalkamat
commented
May 7, 2024
| } | ||
| ] | ||
| } | ||
| } | ||
| Info seq [hh:mm:ss:mss] event: |
There was a problem hiding this comment.
This is example of duplicate configFileDiagEvent
|
Is there a linked bug that this fixes? |
jakebailey
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have following rules on when to send the
configFileDiagEventconfigFileDiagEventconfigFileDiagEventevent for all loaded/looked up projects so that we can figure out if there are errors in config file which is the reason why the file went into inferred projectconfigFileDiagEventconfigFileDiagEventif the diagnostics changed any time program update happensSo this handles that ensuring we arent sending duplicate event
468d91c deletes the unnecessary comment about loading/reloading configured project
f738ccd actual change