-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use explicit extensions for imports within src #58421
Conversation
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary. |
Something weird with the unused baselines check? |
Weird, will take a look later. |
@andrewbranch Is there a way to force this to always be required, even though we're currently being treated as CommonJS? |
Not in tsc. You can set |
I'll whip up a lint rule and set that, thanks! |
I know eslint-plugin-import has a rule for that; not sure about others. |
Sanity checked, and reverting all changes in src, running |
This is extracted from #58419.
Doing this now would reduce churn, but I'm not 100% certain how we can avoid adding the "wrong" kind of imports in the future beforeLint rule!"type": "module"
?