-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolated declarations fix signature serialization scoping #58409
Merged
jakebailey
merged 12 commits into
microsoft:main
from
bloomberg:isolated-declarations-fix-sig-scoping
May 10, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fdcae86
Updated baseline.
dragomirtitian b0231f7
Updated baselines
dragomirtitian 9317c6b
Revert basline to contain expansions.
dragomirtitian 8753792
Fix signature scoping.
dragomirtitian 3621579
Removed baseline files.
dragomirtitian 73c9509
Removed redundant tests.
dragomirtitian b9e6523
Reduce NodeBuilderContext copying and polymorphism
dragomirtitian c68c4f5
Fix regression in node reuse.
dragomirtitian 5263634
Improve test for symbol is the same at the new location.
dragomirtitian d288055
Consider export symbols for symbol tracking in type node reuse.
dragomirtitian fa7e6a0
Switched to using nodeflags to find synthetic scopes in name resolution
dragomirtitian 9c3d5ff
Switch to getExportSymbolOfValueSymbolIfExported to get the export sy…
dragomirtitian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NamedTupleMember
seemed to be missing here. This meant that tuple member names were being funneled throughtrackExistingEntityName
even when other declaration names were not.