Validate the options passed in are numbers instead of strings for our custom commandline options #58388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
src/compiler/program.ts
Outdated
| @@ -1550,6 +1551,11 @@ export function createProgram(rootNamesOrOptions: readonly string[] | CreateProg | |||
| const createProgramOptions = isArray(rootNamesOrOptions) ? createCreateProgramOptions(rootNamesOrOptions, _options!, _host, _oldProgram, _configFileParsingDiagnostics) : rootNamesOrOptions; // TODO: GH#18217 | |||
| const { rootNames, options, configFileParsingDiagnostics, projectReferences, typeScriptVersion } = createProgramOptions; | |||
| let { oldProgram } = createProgramOptions; | |||
| for (const option of commandLineOptionOfCustomType) { | |||
| if (hasProperty(options, option.name)) { | |||
| if (typeof options[option.name] === "string") throw new Error(`Found option: ${option.name} that is string and expected number/enum value.`); | |||
There was a problem hiding this comment.
Suggested change
| if (typeof options[option.name] === "string") throw new Error(`Found option: ${option.name} that is string and expected number/enum value.`); | |
| if (typeof options[option.name] === "string") { | |
| throw new Error(`${option.name} is a string value; tsconfig JSON must be parsed with zzzz before passing to createProgram`); | |
| } |
Replace zzzz with whatever the right function is
There was a problem hiding this comment.
we have so many ways thats why i didnt want to name the function name
jakebailey
approved these changes
May 1, 2024
andrewbranch
approved these changes
May 1, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @RyanCavanaugh
There are only 7 options that need to be checked so i think should be ok to check that irrespective of setting some symbol or something on our parsed option and not verify it.