Rephrase error messages on backrererences. #58310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
DanielRosenwasser
requested review from
weswigham,
rbuckton,
jakebailey and
gabritto
jakebailey
approved these changes
Apr 24, 2024
gabritto
approved these changes
Apr 24, 2024
DanielRosenwasser
force-pushed
the
rephraseBackreferenceMessage
branch
from
3a143e6
to
d07e867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rephrases "decimal capturing group" as just a "backreference".
I would actually call out the backreference number, but the scanner's
ErrorCallbackonly accepts one parameter, so that can be fixed up in the future.