DOM update 2024-04-16 #58211

sandersn · 2024-04-16T15:09:45Z

For 5.5 beta

dom.asyncIterable adds [Symbol.asyncIterator] and values
Some additions in Visibility types
Minor changes to gamepad types.
New ReadableStream iterator options
Some properties flip between optional/required
Add AbortSignal.any method
Add new CSS*Rules
Add Document.parseHTMLUnsafe, ShadowRoot.setHTMLUnsafe
Minor changes to documentation.
HTMLSelectElement.type is now "select-one" | "select-multiple" instead of string
new performance type LargestContentfulPaint

jakebailey · 2024-04-16T15:33:39Z

typescript-bot · 2024-04-16T15:33:41Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-04-16T15:57:04Z

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58211/merge:

Everything looks good!

typescript-bot · 2024-04-16T16:14:02Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{296,995k (± 0.01%)}	_{297,053k (± 0.00%)}	_{+58k (+ 0.02%)}	_297,041k	_297,069k	_{p=0.006 n=6}
_{Parse Time}	_{2.70s (± 0.61%)}	_{2.69s (± 0.72%)}	_~	_2.67s	_2.72s	_{p=0.871 n=6}
_{Bind Time}	_{0.82s (± 0.77%)}	_{0.82s (± 0.63%)}	_~	_0.81s	_0.82s	_{p=0.386 n=6}
_{Check Time}	_{8.33s (± 0.37%)}	_{8.33s (± 0.21%)}	_~	_8.30s	_8.35s	_{p=0.747 n=6}
_{Emit Time}	_{7.06s (± 0.23%)}	_{7.06s (± 0.38%)}	_~	_7.02s	_7.08s	_{p=0.806 n=6}
_{Total Time}	_{18.90s (± 0.23%)}	_{18.90s (± 0.17%)}	_~	_18.86s	_18.94s	_{p=0.808 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,053k (± 0.94%)}	_{192,438k (± 0.74%)}	_~	_191,757k	_195,314k	_{p=0.471 n=6}
_{Parse Time}	_{1.36s (± 1.21%)}	_{1.36s (± 0.38%)}	_~	_1.35s	_1.36s	_{p=0.794 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.58s (± 0.37%)}	_{9.57s (± 0.64%)}	_~	_9.47s	_9.64s	_{p=0.687 n=6}
_{Emit Time}	_{2.61s (± 0.31%)}	_{2.62s (± 0.48%)}	_~	_2.60s	_2.64s	_{p=0.282 n=6}
_{Total Time}	_{14.26s (± 0.21%)}	_{14.27s (± 0.45%)}	_~	_14.16s	_14.34s	_{p=0.809 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{348,869k (± 0.00%)}	_{348,851k (± 0.01%)}	_~	_348,819k	_348,868k	_{p=0.127 n=6}
_{Parse Time}	_{2.55s (± 0.54%)}	_{2.56s (± 0.69%)}	_~	_2.53s	_2.58s	_{p=1.000 n=6}
_{Bind Time}	_{0.89s (± 0.46%)}	_{0.89s (± 0.71%)}	_~	_0.88s	_0.90s	_{p=0.673 n=6}
_{Check Time}	_{7.09s (± 0.66%)}	_{7.05s (± 0.59%)}	_~	_6.99s	_7.10s	_{p=0.170 n=6}
_{Emit Time}	_{4.06s (± 0.36%)}	_{4.05s (± 0.43%)}	_~	_4.03s	_4.08s	_{p=0.417 n=6}
_{Total Time}	_{14.60s (± 0.37%)}	_{14.55s (± 0.34%)}	_~	_14.48s	_14.62s	_{p=0.147 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,972k (± 0.01%)}	_{302,989k (± 0.01%)}	_~	_302,969k	_303,004k	_{p=0.173 n=6}
_{Parse Time}	_{2.95s (± 1.53%)}	_{2.98s (± 1.32%)}	_~	_2.92s	_3.03s	_{p=0.170 n=6}
_{Bind Time}	_{1.44s (± 0.62%)}	_{1.44s (± 0.44%)}	_~	_1.43s	_1.45s	_{p=1.000 n=6}
_{Check Time}	_{9.38s (± 0.50%)}	_{9.38s (± 0.16%)}	_~	_9.36s	_9.40s	_{p=0.807 n=6}
_{Emit Time}	_{5.32s (± 0.51%)}	_{5.30s (± 0.57%)}	_~	_5.26s	_5.34s	_{p=0.334 n=6}
_{Total Time}	_{19.08s (± 0.49%)}	_{19.10s (± 0.26%)}	_~	_19.03s	_19.17s	_{p=0.629 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,613k (± 0.00%)}	_{511,692k (± 0.01%)}	_{+79k (+ 0.02%)}	_511,650k	_511,753k	_{p=0.005 n=6}
_{Parse Time}	_{2.71s (± 0.89%)}	_{2.70s (± 0.89%)}	_~	_2.67s	_2.73s	_{p=0.626 n=6}
_{Bind Time}	_{0.98s (± 0.85%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.209 n=6}
_{Check Time}	_{17.25s (± 0.21%)}	_{17.29s (± 0.29%)}	_~	_17.22s	_17.36s	_{p=0.199 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.94s (± 0.25%)}	_{20.98s (± 0.31%)}	_~	_20.91s	_21.08s	_{p=0.377 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,748,236k (± 0.00%)}	_{1,748,309k (± 0.00%)}	_{+73k (+ 0.00%)}	_1,748,254k	_1,748,347k	_{p=0.008 n=6}
_{Parse Time}	_{9.93s (± 0.28%)}	_{9.96s (± 0.52%)}	_~	_9.90s	_10.04s	_{p=0.466 n=6}
_{Bind Time}	_{3.35s (± 0.38%)}	_{3.36s (± 1.05%)}	_~	_3.32s	_3.42s	_{p=0.743 n=6}
_{Check Time}	_{81.95s (± 0.41%)}	_{81.81s (± 0.31%)}	_~	_81.46s	_82.22s	_{p=0.471 n=6}
_{Emit Time}	_{0.20s (± 2.62%)}	_{0.21s (± 6.02%)}	_~	_0.19s	_0.22s	_{p=0.077 n=6}
_{Total Time}	_{95.43s (± 0.34%)}	_{95.34s (± 0.24%)}	_~	_95.10s	_95.74s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,306,658k (± 0.04%)}	_{2,306,945k (± 0.05%)}	_~	_2,305,247k	_2,308,180k	_{p=0.575 n=6}
_{Parse Time}	_{7.39s (± 0.64%)}	_{7.39s (± 0.81%)}	_~	_7.34s	_7.50s	_{p=1.000 n=6}
_{Bind Time}	_{2.72s (± 0.54%)}	_{2.74s (± 0.63%)}	_{+0.02s (+ 0.86%)}	_2.72s	_2.77s	_{p=0.036 n=6}
_{Check Time}	_{49.36s (± 0.69%)}	_{49.20s (± 0.66%)}	_~	_48.90s	_49.80s	_{p=0.298 n=6}
_{Emit Time}	_{3.94s (± 2.42%)}	_{3.88s (± 1.86%)}	_~	_3.79s	_3.96s	_{p=0.230 n=6}
_{Total Time}	_{63.43s (± 0.61%)}	_{63.20s (± 0.65%)}	_~	_62.82s	_63.96s	_{p=0.336 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_{Memory used}	_{2,381,320k (± 0.03%)}	_{2,380,984k (± 0.03%)}	_~	_2,380,152k	_2,381,693k	_{p=0.575 n=6}
_{Parse Time}	_{6.21s (± 0.47%)}	_{6.18s (± 0.87%)}	_~	_6.11s	_6.24s	_{p=0.871 n=6}
_{Bind Time}	_{2.09s (± 1.71%)}	_{2.06s (± 1.02%)}	_~	_2.02s	_2.08s	_{p=0.089 n=6}
_{Check Time}	_{40.23s (± 0.39%)}	_{40.18s (± 0.33%)}	_~	_39.97s	_40.33s	_{p=0.689 n=6}
_{Emit Time}	_{3.24s (± 4.86%)}	_{3.18s (± 1.59%)}	_~	_3.14s	_3.26s	_{p=0.422 n=6}
_{Total Time}	_{51.77s (± 0.59%)}	_{51.61s (± 0.32%)}	_~	_51.38s	_51.82s	_{p=0.230 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{419,088k (± 0.01%)}	_{419,134k (± 0.01%)}	_~	_419,104k	_419,172k	_{p=0.066 n=6}
_{Parse Time}	_{4.18s (± 0.47%)}	_{4.21s (± 0.42%)}	_~	_4.19s	_4.24s	_{p=0.054 n=6}
_{Bind Time}	_{1.60s (± 1.27%)}	_{1.60s (± 1.04%)}	_~	_1.58s	_1.62s	_{p=1.000 n=6}
_{Check Time}	_{22.33s (± 0.25%)}	_{22.27s (± 0.49%)}	_~	_22.16s	_22.41s	_{p=0.422 n=6}
_{Emit Time}	_{1.71s (± 1.45%)}	_{1.72s (± 0.68%)}	_~	_1.70s	_1.73s	_{p=0.684 n=6}
_{Total Time}	_{29.83s (± 0.22%)}	_{29.80s (± 0.32%)}	_~	_29.68s	_29.91s	_{p=0.748 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,914,035k (± 0.00%)}	_{2,914,128k (± 0.00%)}	_~	_2,913,976k	_2,914,238k	_{p=0.230 n=6}
_{Parse Time}	_{16.46s (± 0.36%)}	_{16.49s (± 0.38%)}	_~	_16.40s	_16.57s	_{p=0.420 n=6}
_{Bind Time}	_{4.94s (± 1.64%)}	_{5.04s (± 2.76%)}	_~	_4.89s	_5.20s	_{p=0.172 n=6}
_{Check Time}	_{87.95s (± 0.39%)}	_{87.84s (± 0.38%)}	_~	_87.46s	_88.25s	_{p=0.810 n=6}
_{Emit Time}	_{23.45s (± 0.60%)}	_{24.34s (± 7.60%)}	_~	_23.52s	_28.11s	_{p=0.065 n=6}
_{Total Time}	_{132.80s (± 0.19%)}	_{133.70s (± 1.46%)}	_~	_132.65s	_137.64s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{409,364k (± 0.01%)}	_{409,467k (± 0.01%)}	_{+103k (+ 0.03%)}	_409,413k	_409,530k	_{p=0.020 n=6}
_{Parse Time}	_{3.92s (± 0.83%)}	_{3.91s (± 1.13%)}	_~	_3.86s	_3.98s	_{p=0.868 n=6}
_{Bind Time}	_{1.66s (± 1.19%)}	_{1.66s (± 0.74%)}	_~	_1.64s	_1.67s	_{p=0.742 n=6}
_{Check Time}	_{16.95s (± 0.33%)}	_{16.97s (± 0.43%)}	_~	_16.89s	_17.06s	_{p=0.748 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.53s (± 0.24%)}	_{22.54s (± 0.22%)}	_~	_22.48s	_22.60s	_{p=0.808 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{672,009k (± 0.01%)}	_{672,337k (± 0.01%)}	_{+328k (+ 0.05%)}	_672,236k	_672,470k	_{p=0.005 n=6}
_{Parse Time}	_{4.12s (± 0.41%)}	_{4.13s (± 0.66%)}	_~	_4.09s	_4.17s	_{p=0.376 n=6}
_{Bind Time}	_{1.87s (± 1.14%)}	_{1.88s (± 0.99%)}	_~	_1.86s	_1.90s	_{p=0.564 n=6}
_{Check Time}	_{3.44s (± 0.22%)}	_{3.43s (± 0.89%)}	_~	_3.38s	_3.45s	_{p=0.869 n=6}
_{Emit Time}	_{0.03s (± 0.00%)}	_{0.03s (±14.39%)}	_~	_0.02s	_0.03s	_{p=0.405 n=6}
_{Total Time}	_{9.47s (± 0.31%)}	_{9.46s (± 0.52%)}	_~	_9.40s	_9.54s	_{p=0.809 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-04-16T17:11:04Z

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/58211/merge:

Everything looks good!

sandersn · 2024-04-16T19:28:32Z

Requires slightly more memory presumably because it adds a few more types and properties.

jakebailey · 2024-04-17T18:02:33Z

@typescript-bot run dt

typescript-bot · 2024-04-17T18:02:36Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`run dt`	✅ Started	👀 Results

typescript-bot · 2024-04-17T18:27:00Z

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: webrtc
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/webrtc/RTCPeerConnection.d.ts
  51:5  error  TypeScript@local compile error: 
All declarations of 'local' must have identical modifiers                                                                                                        @definitelytyped/expect
  51:5  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'local' must be of type 'RTCIceCandidate', but here has type 'RTCIceCandidate | undefined'   @definitelytyped/expect
  52:5  error  TypeScript@local compile error: 
All declarations of 'remote' must have identical modifiers                                                                                                       @definitelytyped/expect
  52:5  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'remote' must be of type 'RTCIceCandidate', but here has type 'RTCIceCandidate | undefined'  @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.20_typescript@5.5.0-dev.20240417/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.20_typescript@5.5.0-dev.20240417/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

jakebailey · 2024-04-17T18:30:23Z

Ah, webrtc, our old friend

sandersn · 2024-04-18T22:50:01Z

Yeah, that's expected, since types/webrtc is supposed to be a superset of whatever's in the DOM.

I'll merge this tomorrow after I merge all the test baseline conflicts. Is this the result of the new performance stats? Or maybe it's the generated-type spans.

jakebailey · 2024-04-18T22:51:46Z

Is this the result of the new performance stats? Or maybe it's the generated-type spans.

Both, probably.

DOM update 2024-04-16

861e005

typescript-bot assigned sandersn Apr 16, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 16, 2024

sandersn requested a review from DanielRosenwasser April 16, 2024 15:16

Merge branch 'main' into dom-update-2024-04-16

e130863

sandersn merged commit e04a27c into main Apr 19, 2024
25 checks passed

sandersn deleted the dom-update-2024-04-16 branch April 19, 2024 15:52

iisaduan mentioned this pull request Apr 23, 2024

[webrtc] update for TS 5.5 DefinitelyTyped/DefinitelyTyped#69424

Merged

1 task

MattiasBuelens mentioned this pull request Apr 24, 2024

ReadableStream should be an async iterable whatwg/streams#778

Closed

DanielRosenwasser mentioned this pull request Apr 24, 2024

lib.d.ts Updates for TypeScript 5.5 #57474

Closed

Teamop mentioned this pull request May 10, 2024

Missing the AbortSignal.any() function #58026

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DOM update 2024-04-16 #58211

DOM update 2024-04-16 #58211

sandersn commented Apr 16, 2024 •

edited

Loading

jakebailey commented Apr 16, 2024

typescript-bot commented Apr 16, 2024 •

edited

Loading

typescript-bot commented Apr 16, 2024

typescript-bot commented Apr 16, 2024

tsc

typescript-bot commented Apr 16, 2024

sandersn commented Apr 16, 2024

jakebailey commented Apr 17, 2024

typescript-bot commented Apr 17, 2024 •

edited

Loading

typescript-bot commented Apr 17, 2024

jakebailey commented Apr 17, 2024

sandersn commented Apr 18, 2024

jakebailey commented Apr 18, 2024

DOM update 2024-04-16 #58211

DOM update 2024-04-16 #58211

Conversation

sandersn commented Apr 16, 2024 • edited Loading

jakebailey commented Apr 16, 2024

typescript-bot commented Apr 16, 2024 • edited Loading

typescript-bot commented Apr 16, 2024

typescript-bot commented Apr 16, 2024

tsc

typescript-bot commented Apr 16, 2024

sandersn commented Apr 16, 2024

jakebailey commented Apr 17, 2024

typescript-bot commented Apr 17, 2024 • edited Loading

typescript-bot commented Apr 17, 2024

jakebailey commented Apr 17, 2024

sandersn commented Apr 18, 2024

jakebailey commented Apr 18, 2024

sandersn commented Apr 16, 2024 •

edited

Loading

typescript-bot commented Apr 16, 2024 •

edited

Loading

typescript-bot commented Apr 17, 2024 •

edited

Loading