Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify CONTRIBUTING.md and the issue templates bug_report.yml and feature_request.yml to reduce duplicate issues and improve the quality of further submitted issues #58155

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

graphemecluster
Copy link
Contributor

@graphemecluster graphemecluster commented Apr 12, 2024

Fixes #56007
Fixes #58206

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Apr 12, 2024
Copy link
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a bunch of extraneous changes that weren't described in the linked bug

CONTRIBUTING.md Outdated Show resolved Hide resolved
@graphemecluster
Copy link
Contributor Author

I am willing to make such modifications, but are there any particular reasons why these changes would not be desirable? Are they having adverse effects?

@RyanCavanaugh
Copy link
Member

I am willing to make such modifications, but are there any particular reasons why these changes would not be desirable? Are they having adverse effects?

Including unrelated changes in a PR is an adverse effect on its own terms. If you want to change other aspects of the template, file another bug.

@graphemecluster graphemecluster changed the title Encourage the use of search engines to reduce duplicate issues Modify CONTRIBUTING.md and the issue templates bug_report.yml and feature_request.yml to reduce duplicate issues and improve the quality of further submitted issues Apr 15, 2024
… `feature_request.yml` to reduce duplicate issues and improve the quality of further submitted issues
@graphemecluster
Copy link
Contributor Author

I guess the alterations should be something acceptable now

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RyanCavanaugh RyanCavanaugh merged commit 4900c7f into microsoft:main Apr 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
3 participants