Don't clear _children on NodeArrays #58069

jakebailey · 2024-04-03T23:43:50Z

Noticed this in #58045; _children is never read by anyone from arrays. There isn't a need to clear it. And clearing it probably causes worse perf as we're tacking yet another random prop on.

No doubt, we won't see any perf change in the tester since this only affected incremental mode, but it's probably real in the editor.

jakebailey · 2024-04-03T23:45:20Z

@typescript-bot perf test this

typescript-bot · 2024-04-03T23:45:23Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-04-04T00:26:16Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,675k (± 0.01%)}	_{295,653k (± 0.01%)}	_~	_295,625k	_295,690k	_{p=0.173 n=6}
_{Parse Time}	_{3.93s (± 0.30%)}	_{3.93s (± 0.44%)}	_~	_3.90s	_3.95s	_{p=0.934 n=6}
_{Bind Time}	_{1.23s (± 1.11%)}	_{1.24s (± 0.66%)}	_~	_1.23s	_1.25s	_{p=0.325 n=6}
_{Check Time}	_{12.05s (± 0.55%)}	_{12.05s (± 0.21%)}	_~	_12.00s	_12.07s	_{p=0.745 n=6}
_{Emit Time}	_{10.50s (± 0.13%)}	_{10.47s (± 0.21%)}	_{-0.03s (- 0.27%)}	_10.44s	_10.50s	_{p=0.040 n=6}
_{Total Time}	_{27.71s (± 0.19%)}	_{27.68s (± 0.10%)}	_~	_27.65s	_27.72s	_{p=0.286 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{194,415k (± 0.95%)}	_{193,958k (± 1.07%)}	_~	_191,974k	_195,935k	_{p=0.689 n=6}
_{Parse Time}	_{2.04s (± 1.97%)}	_{2.03s (± 1.72%)}	_~	_1.99s	_2.09s	_{p=0.628 n=6}
_{Bind Time}	_{1.08s (± 1.08%)}	_{1.08s (± 0.75%)}	_~	_1.07s	_1.09s	_{p=0.498 n=6}
_{Check Time}	_{13.93s (± 0.75%)}	_{13.91s (± 0.43%)}	_~	_13.84s	_14.02s	_{p=0.936 n=6}
_{Emit Time}	_{3.86s (± 0.45%)}	_{3.87s (± 0.65%)}	_~	_3.84s	_3.91s	_{p=0.463 n=6}
_{Total Time}	_{20.91s (± 0.66%)}	_{20.90s (± 0.27%)}	_~	_20.81s	_20.95s	_{p=0.810 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,431k (± 0.00%)}	_{347,447k (± 0.01%)}	_~	_347,418k	_347,466k	_{p=0.199 n=6}
_{Parse Time}	_{3.69s (± 1.02%)}	_{3.69s (± 0.56%)}	_~	_3.67s	_3.73s	_{p=0.368 n=6}
_{Bind Time}	_{1.37s (± 0.60%)}	_{1.37s (± 0.55%)}	_~	_1.36s	_1.38s	_{p=0.340 n=6}
_{Check Time}	_{10.17s (± 0.49%)}	_{10.19s (± 0.20%)}	_~	_10.16s	_10.22s	_{p=0.250 n=6}
_{Emit Time}	_{6.02s (± 0.30%)}	_{6.02s (± 0.57%)}	_~	_5.98s	_6.08s	_{p=0.871 n=6}
_{Total Time}	_{21.25s (± 0.31%)}	_{21.28s (± 0.26%)}	_~	_21.18s	_21.33s	_{p=0.336 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,803k (± 0.01%)}	_{302,813k (± 0.01%)}	_~	_302,785k	_302,848k	_{p=0.520 n=6}
_{Parse Time}	_{2.97s (± 0.58%)}	_{2.96s (± 1.11%)}	_~	_2.92s	_3.01s	_{p=0.625 n=6}
_{Bind Time}	_{1.48s (± 0.55%)}	_{1.48s (± 0.51%)}	_~	_1.47s	_1.49s	_{p=0.340 n=6}
_{Check Time}	_{9.27s (± 0.35%)}	_{9.25s (± 0.47%)}	_~	_9.20s	_9.32s	_{p=0.519 n=6}
_{Emit Time}	_{5.30s (± 0.74%)}	_{5.32s (± 0.66%)}	_~	_5.28s	_5.38s	_{p=0.191 n=6}
_{Total Time}	_{19.00s (± 0.36%)}	_{19.01s (± 0.24%)}	_~	_18.95s	_19.07s	_{p=1.000 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,249k (± 0.02%)}	_{510,178k (± 0.01%)}	_~	_510,123k	_510,220k	_{p=0.128 n=6}
_{Parse Time}	_{3.94s (± 0.45%)}	_{3.95s (± 0.76%)}	_~	_3.92s	_4.01s	_{p=0.413 n=6}
_{Bind Time}	_{1.46s (± 0.91%)}	_{1.47s (± 0.80%)}	_~	_1.45s	_1.48s	_{p=0.216 n=6}
_{Check Time}	_{25.42s (± 0.40%)}	_{25.43s (± 0.33%)}	_~	_25.37s	_25.55s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{30.81s (± 0.33%)}	_{30.85s (± 0.34%)}	_~	_30.76s	_31.02s	_{p=0.261 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,744,894k (± 0.00%)}	_{1,744,938k (± 0.00%)}	_~	_1,744,879k	_1,744,998k	_{p=0.230 n=6}
_{Parse Time}	_{6.59s (± 0.55%)}	_{6.61s (± 0.42%)}	_~	_6.58s	_6.65s	_{p=0.572 n=6}
_{Bind Time}	_{2.39s (± 0.82%)}	_{2.38s (± 0.62%)}	_~	_2.36s	_2.40s	_{p=0.869 n=6}
_{Check Time}	_{56.75s (± 0.14%)}	_{56.70s (± 0.26%)}	_~	_56.52s	_56.93s	_{p=0.520 n=6}
_{Emit Time}	_{0.13s (± 3.87%)}	_{0.13s (± 0.00%)}	_~	_0.13s	_0.13s	_{p=0.174 n=6}
_{Total Time}	_{65.86s (± 0.13%)}	_{65.83s (± 0.25%)}	_~	_65.64s	_66.07s	_{p=0.521 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,399,990k (± 0.02%)}	_{2,400,060k (± 0.02%)}	_~	_2,399,690k	_2,401,227k	_{p=0.378 n=6}
_{Parse Time}	_{4.99s (± 0.66%)}	_{4.98s (± 1.00%)}	_~	_4.92s	_5.06s	_{p=0.748 n=6}
_{Bind Time}	_{1.92s (± 0.83%)}	_{1.92s (± 1.16%)}	_~	_1.89s	_1.95s	_{p=1.000 n=6}
_{Check Time}	_{33.92s (± 0.37%)}	_{33.89s (± 0.34%)}	_~	_33.81s	_34.09s	_{p=0.422 n=6}
_{Emit Time}	_{2.69s (± 1.48%)}	_{2.70s (± 1.17%)}	_~	_2.66s	_2.75s	_{p=1.000 n=6}
_{Total Time}	_{43.53s (± 0.29%)}	_{43.52s (± 0.30%)}	_~	_43.38s	_43.72s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,345k (± 0.01%)}	_{416,320k (± 0.01%)}	_~	_416,273k	_416,375k	_{p=0.298 n=6}
_{Parse Time}	_{2.75s (± 0.58%)}	_{2.73s (± 2.45%)}	_~	_2.60s	_2.78s	_{p=0.871 n=6}
_{Bind Time}	_{1.08s (± 0.38%)}	_{1.10s (± 4.94%)}	_~	_1.07s	_1.21s	_{p=0.858 n=6}
_{Check Time}	_{15.43s (± 0.38%)}	_{15.45s (± 0.26%)}	_~	_15.38s	_15.49s	_{p=0.748 n=6}
_{Emit Time}	_{1.12s (± 1.18%)}	_{1.12s (± 1.78%)}	_~	_1.09s	_1.15s	_{p=0.739 n=6}
_{Total Time}	_{20.38s (± 0.24%)}	_{20.39s (± 0.28%)}	_~	_20.29s	_20.44s	_{p=0.572 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,907,120k (± 0.00%)}	_{2,907,170k (± 0.00%)}	_~	_2,907,136k	_2,907,239k	_{p=0.378 n=6}
_{Parse Time}	_{15.93s (± 0.41%)}	_{15.90s (± 0.25%)}	_~	_15.86s	_15.96s	_{p=0.571 n=6}
_{Bind Time}	_{5.05s (± 0.37%)}	_{5.03s (± 0.55%)}	_~	_5.00s	_5.07s	_{p=0.294 n=6}
_{Check Time}	_{87.36s (± 0.57%)}	_{87.26s (± 0.35%)}	_~	_86.92s	_87.74s	_{p=0.873 n=6}
_{Emit Time}	_{25.21s (± 9.90%)}	_{23.63s (± 0.55%)}	_~	_23.39s	_23.74s	_{p=0.470 n=6}
_{Total Time}	_{133.54s (± 2.03%)}	_{131.82s (± 0.25%)}	_~	_131.49s	_132.41s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,995k (± 0.01%)}	_{408,955k (± 0.02%)}	_~	_408,895k	_409,047k	_{p=0.378 n=6}
_{Parse Time}	_{4.80s (± 0.76%)}	_{4.78s (± 0.80%)}	_~	_4.75s	_4.84s	_{p=0.687 n=6}
_{Bind Time}	_{2.06s (± 0.65%)}	_{2.05s (± 0.59%)}	_~	_2.04s	_2.07s	_{p=0.507 n=6}
_{Check Time}	_{20.91s (± 0.27%)}	_{20.92s (± 0.22%)}	_~	_20.88s	_21.00s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{27.77s (± 0.30%)}	_{27.76s (± 0.26%)}	_~	_27.67s	_27.89s	_{p=0.572 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,554k (± 0.02%)}	_{513,546k (± 0.03%)}	_~	_513,404k	_513,772k	_{p=0.810 n=6}
_{Parse Time}	_{4.91s (± 0.44%)}	_{4.92s (± 0.24%)}	_~	_4.90s	_4.93s	_{p=0.292 n=6}
_{Bind Time}	_{2.32s (± 0.92%)}	_{2.31s (± 0.85%)}	_~	_2.29s	_2.34s	_{p=0.368 n=6}
_{Check Time}	_{4.30s (± 0.41%)}	_{4.34s (± 0.59%)}	_{+0.03s (+ 0.77%)}	_4.31s	_4.37s	_{p=0.046 n=6}
_{Emit Time}	_{0.11s (± 3.65%)}	_{0.11s (± 0.00%)}	_~	_0.11s	_0.11s	_{p=0.405 n=6}
_{Total Time}	_{11.64s (± 0.35%)}	_{11.67s (± 0.27%)}	_~	_11.64s	_11.71s	_{p=0.228 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,563ms (± 0.43%)}	_{3,563ms (± 0.34%)}	_~	_3,546ms	_3,582ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{8,299ms (± 0.23%)}	_{8,338ms (± 0.32%)}	_{+39ms (+ 0.47%)}	_8,298ms	_8,379ms	_{p=0.031 n=6}
_{Req 3 - references}	_{474ms (± 0.46%)}	_{476ms (± 1.07%)}	_~	_472ms	_486ms	_{p=0.570 n=6}
_{Req 4 - navto}	_{407ms (± 0.18%)}	_{407ms (± 0.36%)}	_~	_404ms	_408ms	_{p=0.604 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{131ms (± 0.42%)}	_{130ms (± 0.58%)}	_~	_129ms	_131ms	_{p=0.137 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,707ms (± 0.79%)}	_{3,706ms (± 1.07%)}	_~	_3,668ms	_3,775ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{6,118ms (± 0.55%)}	_{6,105ms (± 0.23%)}	_~	_6,086ms	_6,120ms	_{p=0.688 n=6}
_{Req 3 - references}	_{494ms (± 0.31%)}	_{497ms (± 1.15%)}	_~	_491ms	_505ms	_{p=0.463 n=6}
_{Req 4 - navto}	_{446ms (± 0.78%)}	_{446ms (± 0.51%)}	_~	_441ms	_447ms	_{p=0.397 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{109ms (± 0.00%)}	_{108ms (± 1.23%)}	_~	_106ms	_109ms	_{p=0.176 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,893ms (± 0.39%)}	_{3,891ms (± 1.03%)}	_~	_3,852ms	_3,964ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{2,430ms (± 1.04%)}	_{2,440ms (± 0.60%)}	_~	_2,422ms	_2,455ms	_{p=0.230 n=6}
_{Req 3 - references}	_{150ms (± 2.66%)}	_{148ms (± 0.93%)}	_~	_146ms	_149ms	_{p=0.369 n=6}
_{Req 4 - navto}	_{557ms (± 1.10%)}	_{553ms (± 1.05%)}	_~	_544ms	_560ms	_{p=0.467 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{454ms (± 2.07%)}	_{452ms (± 1.48%)}	_~	_446ms	_465ms	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{222.85ms (± 0.18%)}	_{222.86ms (± 0.19%)}	_~	_220.50ms	_227.50ms	_{p=0.976 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.54ms (± 0.16%)}	_{227.36ms (± 0.17%)}	_{-0.18ms (- 0.08%)}	_225.53ms	_231.98ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{329.69ms (± 0.31%)}	_{329.64ms (± 0.31%)}	_~	_321.60ms	_338.92ms	_{p=0.292 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{329.74ms (± 0.31%)}	_{329.78ms (± 0.30%)}	_~	_321.46ms	_338.83ms	_{p=0.964 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-04-04T04:41:31Z

Not significant, but still an ok cleanup and one that will probably happen due to #58045 anyway...

Don't clear _children on ArrayNodes

cc2def0

typescript-bot assigned jakebailey Apr 3, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 3, 2024

jakebailey changed the title ~~Don't clear _children on ArrayNodes~~ Don't clear _children on NodeArrays Apr 3, 2024

jakebailey mentioned this pull request Apr 3, 2024

Monomorphize allocators for tsserver/public API, just like core compiler #58045

Merged

rbuckton approved these changes Apr 4, 2024

View reviewed changes

jakebailey merged commit 772c290 into microsoft:main Apr 4, 2024
25 checks passed

jakebailey deleted the dont-clear-children-on-nodearrays branch April 4, 2024 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't clear _children on NodeArrays #58069

Don't clear _children on NodeArrays #58069

jakebailey commented Apr 3, 2024 •

edited

Loading

jakebailey commented Apr 3, 2024

typescript-bot commented Apr 3, 2024 •

edited

Loading

typescript-bot commented Apr 4, 2024

tsc

tsserver

startup

jakebailey commented Apr 4, 2024

Don't clear _children on NodeArrays #58069

Don't clear _children on NodeArrays #58069

Conversation

jakebailey commented Apr 3, 2024 • edited Loading

jakebailey commented Apr 3, 2024

typescript-bot commented Apr 3, 2024 • edited Loading

typescript-bot commented Apr 4, 2024

tsc

tsserver

startup

jakebailey commented Apr 4, 2024

jakebailey commented Apr 3, 2024 •

edited

Loading

typescript-bot commented Apr 3, 2024 •

edited

Loading