Adjust the node builder compatible reference check to handle aliased tuples #58066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check is needed to handle checking if the input node actually meets the required argument count for the target type (since in JS you can construct a type with fewer type arguments than required and you just get
any
s for the missing ones, and even in TS if the input has errors). Oddly enough, though, the way tuples are constructed can mean you have a reference node (for the alias) that points at another reference type (for the actual tuple) which have different type argument lists. As-is, this was disqualifying all cases like that (an alias of a tuple) from reuse (unless, by chance, the alias had the same argument count as the target tuple).