Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unused variable rule a warning, error on warnings for CI #58059

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

jakebailey
Copy link
Member

Some have expressed that an error is a bit too strong, and that a warning would be preferred; this PR makes an unused var a warning, but still ensures hereby lint errors on warnings.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 3, 2024
@jakebailey jakebailey merged commit 4386501 into microsoft:main Apr 3, 2024
25 checks passed
@jakebailey jakebailey deleted the warn-unused branch April 3, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants