Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for String#isWellFormed and String#toWellFormed #58010

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Add types for String#isWellFormed and String#toWellFormed #58010

merged 6 commits into from
Apr 19, 2024

Conversation

andreubotella
Copy link
Contributor

@andreubotella andreubotella commented Mar 31, 2024 •
edited
Loading

These two methods are part of the well-formed Unicode strings proposal, which reached stage 4 in May 2023 and will be part of ES2024.

Fixes #55543.

@andreubotella
Add types for String#isWellFormed and String#toWellFormed
825f726 
These two methods are part of the well-formed Unicode strings proposal
(https://github.com/tc39/proposal-is-usv-string), which reached stage 4 in
May 2023 and will be part of ES2024.

Fixes microsoft#55543.
@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Mar 31, 2024
@andreubotella
Copy link
Contributor Author

@microsoft-github-policy-service agree

sandersn
sandersn requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure looks good. I'd like to stay closer to the method descriptions in the proposal, though.

src/lib/esnext.string.d.ts Outdated Show resolved Hide resolved
src/lib/esnext.string.d.ts Outdated Show resolved Hide resolved
andreubotella and others added 2 commits April 5, 2024 00:54
@andreubotella @sandersn
Update src/lib/esnext.string.d.ts
3b81476 
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@andreubotella
Update src/lib/esnext.string.d.ts
96b7f82
@DanielRosenwasser
Copy link
Member

Thanks for the PR! To help users out a bit: in utilities.ts there's a function called getScriptTargetFeatures that recommends using the appropriate lib/target setting when someone accesses values that don't seem to exist. Can you update that?

@andreubotella
Copy link
Contributor Author

Thanks for the PR! To help users out a bit: in utilities.ts there's a function called getScriptTargetFeatures that recommends using the appropriate lib/target setting when someone accesses values that don't seem to exist. Can you update that?

Done

@DanielRosenwasser
Copy link
Member

@sandersn are we good to merge?

@DanielRosenwasser DanielRosenwasser merged commit 3480321 into microsoft:main Apr 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@andrewbranch andrewbranch andrewbranch approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@sandersn sandersn

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support isWellFormed and toWellFormed in lib.esnext.d.ts
5 participants
@andreubotella @DanielRosenwasser @sandersn @andrewbranch @typescript-bot