Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline type nodes without position mappings in .types baselines #57963

Merged
merged 7 commits into from
Mar 27, 2024

Conversation

weswigham
Copy link
Member

The underlines themselves, we've talked about in general already, but the underlining logic should get a proper look-over - I think it's pretty good, but I wrote it 😄

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 27, 2024
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underling code seems fine to me; I can't think of a better way to do it.

Of course, the rest of the change is HugeMcLarge and we're going to have to fix all PRs, but I think we were okay with it just to get this coverage.

@rbuckton
Copy link
Member

Unfortunately, due to the number of baselines that changed there are too many files in the diff view and it's crashing the browser tab when I try to comment. I provided some feedback to @weswigham offline.

Otherwise, LGTM.

src/harness/typeWriter.ts Outdated Show resolved Hide resolved
@weswigham weswigham enabled auto-merge (squash) March 27, 2024 20:01
@weswigham weswigham merged commit 6b4eec4 into microsoft:main Mar 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants