Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly add assignees and reviewers for cherry picked PRs #57889

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jakebailey
Copy link
Member

This string script code isn't checked, and I apparently didn't test that assignees and reviewers actually worked. To add assignees and reviewers, you have to do it after creation.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 21, 2024
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Mar 21, 2024

Merge and try it out with this PR 😄

@jakebailey
Copy link
Member Author

I'll try it out with the two new 5.4 patches :(

@jakebailey jakebailey merged commit 39fd535 into microsoft:main Mar 21, 2024
25 checks passed
@jakebailey jakebailey deleted the cherry-pick-reviewers branch March 21, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants