Fixed braceless type tags with types starting with an open parenthesis #57167

Andarist · 2024-01-25T07:58:48Z

typescript-bot · 2024-01-25T07:59:06Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

sandersn · 2024-02-15T22:13:40Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2024-02-15T22:13:42Z

Heya @sandersn, I've started to run the regular perf test suite on this PR at 1f4862e. You can monitor the build here.

typescript-bot · 2024-02-15T22:13:42Z

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 1f4862e. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-15T22:13:42Z

Heya @sandersn, I've started to run the diff-based top-repos suite on this PR at 1f4862e. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-15T22:13:42Z

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at 1f4862e. You can monitor the build here.

Update: The results are in!

sandersn · 2024-02-15T22:20:41Z

@jakebailey do you remember if jsdoc parsing shows up in perf results anymore?

Having a lot of tokens was a significant cause of slowdown in JS comment parsing when I profiled. So I don't want to add tokens unless it's for a good reason.

Is there a lot of un-braced usage of types? It's only supported in TS for compatibility, since the braces are supposed to be required.

typescript-bot · 2024-02-15T22:33:58Z

@sandersn Here are the results of running the user test suite comparing main and refs/pull/57167/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-02-15T23:00:12Z

Hey @sandersn, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-02-16T00:02:30Z

@sandersn Here are the results of running the top-repos suite comparing main and refs/pull/57167/merge:

Everything looks good!

jakebailey · 2024-02-16T16:18:09Z

@typescript-bot perf test this faster

typescript-bot · 2024-02-16T16:18:11Z

Heya @jakebailey, I've started to run the faster perf test suite on this PR at 1f4862e. You can monitor the build here.

Update: The results are in!

jakebailey · 2024-02-16T16:18:26Z

@jakebailey do you remember if jsdoc parsing shows up in perf results anymore?

No, not really.

typescript-bot · 2024-02-16T17:21:00Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,634k (± 0.02%)}	_{295,654k (± 0.01%)}	_~	_295,624k	_295,682k	_{p=0.471 n=6}
_{Parse Time}	_{2.65s (± 0.60%)}	_{2.66s (± 0.34%)}	_~	_2.65s	_2.67s	_{p=0.142 n=6}
_{Bind Time}	_{0.83s (± 1.25%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.090 n=6}
_{Check Time}	_{8.25s (± 0.24%)}	_{8.24s (± 0.34%)}	_~	_8.20s	_8.28s	_{p=0.519 n=6}
_{Emit Time}	_{7.10s (± 0.25%)}	_{7.10s (± 0.37%)}	_~	_7.06s	_7.13s	_{p=0.808 n=6}
_{Total Time}	_{18.83s (± 0.19%)}	_{18.82s (± 0.27%)}	_~	_18.75s	_18.89s	_{p=0.747 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,075k (± 1.29%)}	_{191,612k (± 0.03%)}	_~	_191,554k	_191,681k	_{p=0.229 n=6}
_{Parse Time}	_{1.36s (± 1.28%)}	_{1.36s (± 1.66%)}	_~	_1.33s	_1.38s	_{p=0.464 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.57%)}	_~	_0.72s	_0.73s	_{p=0.405 n=6}
_{Check Time}	_{9.36s (± 0.22%)}	_{9.38s (± 0.21%)}	_~	_9.34s	_9.39s	_{p=0.121 n=6}
_{Emit Time}	_{2.62s (± 0.46%)}	_{2.62s (± 0.52%)}	_~	_2.60s	_2.64s	_{p=0.410 n=6}
_{Total Time}	_{14.06s (± 0.18%)}	_{14.08s (± 0.12%)}	_~	_14.05s	_14.10s	_{p=0.253 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,457k (± 0.01%)}	_{347,480k (± 0.00%)}	_~	_347,460k	_347,490k	_{p=0.065 n=6}
_{Parse Time}	_{2.47s (± 0.54%)}	_{2.48s (± 0.36%)}	_~	_2.47s	_2.49s	_{p=0.273 n=6}
_{Bind Time}	_{0.93s (± 0.81%)}	_{0.92s (± 0.82%)}	_~	_0.91s	_0.93s	_{p=0.062 n=6}
_{Check Time}	_{6.95s (± 0.54%)}	_{6.94s (± 0.17%)}	_~	_6.93s	_6.96s	_{p=0.746 n=6}
_{Emit Time}	_{4.05s (± 0.33%)}	_{4.06s (± 0.40%)}	_~	_4.03s	_4.08s	_{p=0.440 n=6}
_{Total Time}	_{14.40s (± 0.27%)}	_{14.41s (± 0.19%)}	_~	_14.37s	_14.44s	_{p=0.688 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,867k (± 0.00%)}	_{302,864k (± 0.01%)}	_~	_302,841k	_302,893k	_{p=0.748 n=6}
_{Parse Time}	_{2.01s (± 0.66%)}	_{2.04s (± 0.62%)}	_{+0.03s (+ 1.58%)}	_2.02s	_2.05s	_{p=0.009 n=6}
_{Bind Time}	_{1.00s (± 0.51%)}	_{1.00s (± 0.52%)}	_~	_0.99s	_1.00s	_{p=0.069 n=6}
_{Check Time}	_{6.35s (± 0.44%)}	_{6.35s (± 0.42%)}	_~	_6.30s	_6.37s	_{p=0.744 n=6}
_{Emit Time}	_{3.59s (± 0.70%)}	_{3.60s (± 0.42%)}	_~	_3.57s	_3.61s	_{p=0.374 n=6}
_{Total Time}	_{12.95s (± 0.29%)}	_{12.98s (± 0.20%)}	_~	_12.94s	_13.02s	_{p=0.196 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,367k (± 0.01%)}	_{511,385k (± 0.00%)}	_~	_511,370k	_511,404k	_{p=0.575 n=6}
_{Parse Time}	_{2.66s (± 0.28%)}	_{2.64s (± 0.44%)}	_{-0.02s (- 0.75%)}	_2.63s	_2.66s	_{p=0.021 n=6}
_{Bind Time}	_{1.00s (± 0.55%)}	_{0.99s (± 1.18%)}	_~	_0.98s	_1.01s	_{p=0.152 n=6}
_{Check Time}	_{17.32s (± 0.58%)}	_{17.29s (± 0.44%)}	_~	_17.20s	_17.39s	_{p=0.470 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.97s (± 0.44%)}	_{20.91s (± 0.41%)}	_~	_20.81s	_21.03s	_{p=0.423 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{2,272,172k (± 0.00%)}	_{2,272,163k (± 0.00%)}	_~	_2,272,135k	_2,272,188k	_{p=0.936 n=6}
_{Parse Time}	_{11.94s (± 0.53%)}	_{12.00s (± 1.02%)}	_~	_11.90s	_12.23s	_{p=0.422 n=6}
_{Bind Time}	_{2.62s (± 0.29%)}	_{2.62s (± 0.31%)}	_~	_2.61s	_2.63s	_{p=0.729 n=6}
_{Check Time}	_{102.36s (± 0.44%)}	_{101.96s (± 0.75%)}	_~	_100.88s	_103.28s	_{p=0.230 n=6}
_{Emit Time}	_{0.32s (± 1.28%)}	_{0.32s (± 0.00%)}	_~	_0.32s	_0.32s	_{p=0.405 n=6}
_{Total Time}	_{117.24s (± 0.40%)}	_{116.90s (± 0.58%)}	_~	_116.06s	_118.13s	_{p=0.230 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,412,788k (± 0.02%)}	_{2,412,999k (± 0.02%)}	_~	_2,412,341k	_2,413,643k	_{p=0.575 n=6}
_{Parse Time}	_{4.93s (± 1.07%)}	_{4.94s (± 1.39%)}	_~	_4.85s	_5.01s	_{p=1.000 n=6}
_{Bind Time}	_{1.87s (± 0.79%)}	_{1.87s (± 1.19%)}	_~	_1.83s	_1.90s	_{p=0.858 n=6}
_{Check Time}	_{33.51s (± 0.24%)}	_{33.59s (± 0.36%)}	_~	_33.43s	_33.73s	_{p=0.230 n=6}
_{Emit Time}	_{2.67s (± 1.37%)}	_{2.67s (± 1.60%)}	_~	_2.61s	_2.72s	_{p=0.809 n=6}
_{Total Time}	_{42.98s (± 0.27%)}	_{43.08s (± 0.31%)}	_~	_42.91s	_43.25s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{418,847k (± 0.01%)}	_{418,888k (± 0.00%)}	_{+42k (+ 0.01%)}	_418,871k	_418,904k	_{p=0.013 n=6}
_{Parse Time}	_{2.81s (± 2.20%)}	_{2.77s (± 3.33%)}	_~	_2.64s	_2.88s	_{p=0.462 n=6}
_{Bind Time}	_{1.10s (± 5.17%)}	_{1.12s (± 6.69%)}	_~	_1.07s	_1.23s	_{p=0.788 n=6}
_{Check Time}	_{15.15s (± 0.44%)}	_{15.15s (± 0.16%)}	_~	_15.11s	_15.18s	_{p=0.872 n=6}
_{Emit Time}	_{1.14s (± 1.08%)}	_{1.14s (± 1.90%)}	_~	_1.11s	_1.17s	_{p=1.000 n=6}
_{Total Time}	_{20.20s (± 0.45%)}	_{20.18s (± 0.21%)}	_~	_20.11s	_20.23s	_{p=0.630 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,844,159k (± 0.00%)}	_{2,844,125k (± 0.00%)}	_~	_2,844,101k	_2,844,145k	_{p=0.173 n=6}
_{Parse Time}	_{10.75s (± 0.33%)}	_{10.76s (± 0.18%)}	_~	_10.73s	_10.79s	_{p=0.515 n=6}
_{Bind Time}	_{3.43s (± 0.24%)}	_{3.43s (± 0.37%)}	_~	_3.41s	_3.45s	_{p=0.673 n=6}
_{Check Time}	_{60.57s (± 0.51%)}	_{60.37s (± 0.16%)}	_~	_60.22s	_60.51s	_{p=0.148 n=6}
_{Emit Time}	_{16.24s (± 0.62%)}	_{16.19s (± 0.67%)}	_~	_16.05s	_16.38s	_{p=0.230 n=6}
_{Total Time}	_{90.98s (± 0.35%)}	_{90.75s (± 0.22%)}	_~	_90.46s	_91.01s	_{p=0.230 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{394,142k (± 0.01%)}	_{394,158k (± 0.01%)}	_~	_394,100k	_394,235k	_{p=0.575 n=6}
_{Parse Time}	_{3.12s (± 0.39%)}	_{3.11s (± 0.32%)}	_~	_3.09s	_3.12s	_{p=0.303 n=6}
_{Bind Time}	_{1.39s (± 1.18%)}	_{1.38s (± 1.19%)}	_~	_1.37s	_1.41s	_{p=0.365 n=6}
_{Check Time}	_{14.07s (± 0.41%)}	_{14.08s (± 0.34%)}	_~	_14.03s	_14.16s	_{p=0.630 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.58s (± 0.31%)}	_{18.57s (± 0.25%)}	_~	_18.54s	_18.66s	_{p=1.000 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,409k (± 0.02%)}	_{513,376k (± 0.02%)}	_~	_513,256k	_513,472k	_{p=0.471 n=6}
_{Parse Time}	_{3.28s (± 0.17%)}	_{3.27s (± 0.23%)}	_~	_3.26s	_3.28s	_{p=0.137 n=6}
_{Bind Time}	_{1.54s (± 0.34%)}	_{1.54s (± 0.68%)}	_~	_1.52s	_1.55s	_{p=0.794 n=6}
_{Check Time}	_{2.85s (± 0.60%)}	_{2.87s (± 0.86%)}	_~	_2.84s	_2.90s	_{p=0.327 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 7.90%)}	_~	_0.07s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{7.75s (± 0.31%)}	_{7.76s (± 0.34%)}	_~	_7.73s	_7.80s	_{p=0.747 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Andarist · 2024-03-03T10:52:09Z

Is there a lot of un-braced usage of types? It's only supported in TS for compatibility, since the braces are supposed to be required.

Right. But since they are optional in this context I'd expect this to work (there is an explicit boolean set here that allows it). I don't want this for myself - I'm not using JSDoc types anyway. It's just a problem I noticed when working on #57110 and such a braceless type came there (in the original issue) from the real-world code.

sandersn

I'm not convinced that this is very valuable, but it does fix an inconsistency, and it shouldn't hurt the fast path for scanning jsdoc comment text.

sandersn · 2024-03-27T20:50:59Z

Can you update this PR from main before I merge? There has been a lot of churn in baselines recently.

…ypes

Andarist · 2024-03-27T21:38:47Z

@sandersn done

Fixed braceless type tags with types starting with an open parenthesis

1f4862e

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 25, 2024

sandersn self-requested a review February 15, 2024 22:13

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 15, 2024

sandersn self-assigned this Feb 15, 2024

sandersn requested a review from jakebailey February 15, 2024 22:20

sandersn approved these changes Mar 27, 2024

View reviewed changes

Andarist added 2 commits March 27, 2024 22:36

Merge remote-tracking branch 'origin/main' into fix/jsdoc-braceless-t…

ec848af

…ypes

update baselines

9718898

sandersn added 2 commits April 5, 2024 13:00

Merge branch 'main' into fix/jsdoc-braceless-types

499d1b1

update type baselines

1860759

sandersn merged commit 9ba0800 into microsoft:main Apr 5, 2024
25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed braceless type tags with types starting with an open parenthesis #57167

Fixed braceless type tags with types starting with an open parenthesis #57167

Andarist commented Jan 25, 2024

typescript-bot commented Jan 25, 2024

sandersn commented Feb 15, 2024

typescript-bot commented Feb 15, 2024 •

edited

Loading

typescript-bot commented Feb 15, 2024 •

edited

Loading

typescript-bot commented Feb 15, 2024 •

edited

Loading

typescript-bot commented Feb 15, 2024 •

edited

Loading

sandersn commented Feb 15, 2024

typescript-bot commented Feb 15, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Feb 15, 2024

typescript-bot commented Feb 16, 2024

jakebailey commented Feb 16, 2024

typescript-bot commented Feb 16, 2024 •

edited

Loading

jakebailey commented Feb 16, 2024

typescript-bot commented Feb 16, 2024

tsc

Andarist commented Mar 3, 2024

sandersn left a comment

sandersn commented Mar 27, 2024

Andarist commented Mar 27, 2024

Fixed braceless type tags with types starting with an open parenthesis #57167

Fixed braceless type tags with types starting with an open parenthesis #57167

Conversation

Andarist commented Jan 25, 2024

typescript-bot commented Jan 25, 2024

sandersn commented Feb 15, 2024

typescript-bot commented Feb 15, 2024 • edited Loading

typescript-bot commented Feb 15, 2024 • edited Loading

typescript-bot commented Feb 15, 2024 • edited Loading

typescript-bot commented Feb 15, 2024 • edited Loading

sandersn commented Feb 15, 2024

typescript-bot commented Feb 15, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Feb 15, 2024

typescript-bot commented Feb 16, 2024

jakebailey commented Feb 16, 2024

typescript-bot commented Feb 16, 2024 • edited Loading

jakebailey commented Feb 16, 2024

typescript-bot commented Feb 16, 2024

tsc

Andarist commented Mar 3, 2024

sandersn left a comment

Choose a reason for hiding this comment

sandersn commented Mar 27, 2024

Andarist commented Mar 27, 2024

typescript-bot commented Feb 15, 2024 •

edited

Loading

typescript-bot commented Feb 15, 2024 •

edited

Loading

typescript-bot commented Feb 15, 2024 •

edited

Loading

typescript-bot commented Feb 15, 2024 •

edited

Loading

typescript-bot commented Feb 16, 2024 •

edited

Loading